pitrou commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r433863702
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -42,7 +42,7 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
else()
pitrou commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r419957464
##
File path: cpp/src/arrow/util/bit_util_test.cc
##
@@ -315,6 +318,115 @@ TEST(FirstTimeBitmapWriter, NormalOperation) {
}
}
+std::string BitmapToStri
pitrou commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r419602697
##
File path: cpp/src/arrow/util/bit_util.h
##
@@ -610,6 +618,101 @@ class FirstTimeBitmapWriter {
}
}
+ /// Appends number_of_bits from word to v
pitrou commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r419593319
##
File path: cpp/src/arrow/util/bit_util.h
##
@@ -43,13 +43,18 @@
#if defined(_MSC_VER)
#include
+#include
#pragma intrinsic(_BitScanReverse)
#pragm
pitrou commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413696312
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
else()