pitrou commented on a change in pull request #7172:
URL: https://github.com/apache/arrow/pull/7172#discussion_r425997507
##
File path: cpp/src/arrow/util/io_util.cc
##
@@ -1072,6 +1072,61 @@ Status MemoryMapRemap(void* addr, size_t old_size,
size_t new_size, int fildes,
#endi
pitrou commented on a change in pull request #7172:
URL: https://github.com/apache/arrow/pull/7172#discussion_r425997334
##
File path: cpp/src/arrow/io/file.cc
##
@@ -636,6 +665,9 @@ Result>
MemoryMappedFile::ReadAt(int64_t position,
ARROW_ASSIGN_OR_RAISE(
nbytes,
pitrou commented on a change in pull request #7172:
URL: https://github.com/apache/arrow/pull/7172#discussion_r425167956
##
File path: cpp/src/arrow/io/file.cc
##
@@ -636,6 +665,9 @@ Result>
MemoryMappedFile::ReadAt(int64_t position,
ARROW_ASSIGN_OR_RAISE(
nbytes,
pitrou commented on a change in pull request #7172:
URL: https://github.com/apache/arrow/pull/7172#discussion_r425166680
##
File path: cpp/src/arrow/io/file.cc
##
@@ -262,6 +266,27 @@ class ReadableFile::ReadableFileImpl : public OSFile {
return std::move(buffer);
}
+
pitrou commented on a change in pull request #7172:
URL: https://github.com/apache/arrow/pull/7172#discussion_r425165237
##
File path: cpp/src/arrow/io/caching.cc
##
@@ -171,7 +171,8 @@ Status ReadRangeCache::Cache(std::vector ranges)
{
}
impl_->AddEntries(std::move(en
