[GitHub] [arrow] pitrou commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-12 Thread GitBox
pitrou commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439416979 ## File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] pitrou commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-12 Thread GitBox
pitrou commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439415981 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +37,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the