[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r450371161 ## File path: cpp/src/arrow/scalar_test.cc ## @@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) { ASSERT_RAISES(Invalid,

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r450328412 ## File path: cpp/src/arrow/scalar_test.cc ## @@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) { ASSERT_RAISES(Invalid,

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r450319790 ## File path: cpp/src/arrow/scalar_test.cc ## @@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) { ASSERT_RAISES(Invalid,

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r450314430 ## File path: cpp/src/arrow/scalar_test.cc ## @@ -451,6 +565,127 @@ TEST(TestStructScalar, FieldAccess) { ASSERT_RAISES(Invalid,

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447751371 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar:

[GitHub] [arrow] pitrou commented on a change in pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
pitrou commented on a change in pull request #7519: URL: https://github.com/apache/arrow/pull/7519#discussion_r447732301 ## File path: python/pyarrow/scalar.pxi ## @@ -16,1198 +16,745 @@ # under the License. -_NULL = NA = None +import collections cdef class Scalar: