[GitHub] [arrow] pitrou commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-06 Thread GitBox
pitrou commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-654237098 Looks like the PR needs rebasing and fixing for the latest union changes. This is an automated message from the

[GitHub] [arrow] pitrou commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-01 Thread GitBox
pitrou commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-652256345 Yes, we could. That may have other annoying implications, though (such as `__contains__` not working anymore). I've started a ML discussion.

[GitHub] [arrow] pitrou commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-07-01 Thread GitBox
pitrou commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-652247947 The problem is that it breaks Python semantics in potentially annoying places: ```python >>> import pyarrow as pa

[GitHub] [arrow] pitrou commented on pull request #7519: ARROW-9017: [C++][Python] Refactor scalar bindings

2020-06-30 Thread GitBox
pitrou commented on pull request #7519: URL: https://github.com/apache/arrow/pull/7519#issuecomment-651806049 Ok, at a quick glance, it seems that null container tests work properly regardless: ```python >>> s = set()