[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-08-10 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-671356665 I believe I addressed your comments @bkietz , so I'm going to merge now. This is an automated message from the

[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-08-05 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-669322336 Or perhaps @bkietz . This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-08-05 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-66933 Rebased. @wesm could you perhaps review this? This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-07-16 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-659505609 @wesm You'll probably want to take a look at the codegen changes when you have some time. This is an automated

[GitHub] [arrow] pitrou commented on pull request #7784: ARROW-9402: [C++] Rework portable wrappers for checked integer arithmetic

2020-07-16 Thread GitBox
pitrou commented on pull request #7784: URL: https://github.com/apache/arrow/pull/7784#issuecomment-659504776 I think I finally squashed the horrid Windows preprocessor macro issues (Windows headers define OPTIONAL, but you can't undef it blindly because other subsequent includes may