[GitHub] [arrow] pitrou commented on pull request #9606: ARROW-10405: [C++] IsIn kernel should be able to lookup dictionary in string

2021-03-09 Thread GitBox 


pitrou commented on pull request #9606:
URL: https://github.com/apache/arrow/pull/9606#issuecomment-794048467


   @nealrichardson I'll let you review the R changes and give the final merge.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #9606: ARROW-10405: [C++] IsIn kernel should be able to lookup dictionary in string

2021-03-04 Thread GitBox 


pitrou commented on pull request #9606:
URL: https://github.com/apache/arrow/pull/9606#issuecomment-790546124


   Also note that the current implementation (in `scalar_set_lookup.cc`) is 
suboptimal as it decodes the dictionary array and runs the set lookup for each 
decoded dictionary value. It would be more efficient to compute and cache 
lookup results for distinct dictionary elements. That can be for a later JIRA, 
though.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org