[GitHub] [arrow] rongma1997 commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader

2020-05-15 Thread GitBox 


rongma1997 commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-629175106


   Close this based on the discussions in jira.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] rongma1997 commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader

2020-05-14 Thread GitBox 


rongma1997 commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-629023063


   > Thanks for the PR @rongma1997.
   > 
   > I'm not clear if the failure in ORC is caused by this change. could you 
try rebasing?
   > 
   > I'm also not sure how I feel about moving the setRowCount around without a 
complete implementation for compressed buffers (i.e. I don't know if something 
else will need to change). At least a unit test showing why this is needed 
would be worthwhile.
   
   Thanks for the comment!
   I tried rebasing first but it looks like those errors are not caused by this 
PR?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org