[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-29 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446921213 ## File path: java/memory/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java ## @@ -17,33 +17,107 @@ package

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-29 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446920388 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -78,6 +77,55 @@ public Object run() { Field addressField

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-29 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446920091 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -95,4 +143,26 @@ public static long

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-25 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r445373746 ## File path: java/memory/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java ## @@ -31,19 +28,18 @@ public final long

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-25 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r445373657 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -78,6 +77,55 @@ public Object run() { Field addressField

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-16 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r440907579 ## File path: java/memory/src/main/java/io/netty/buffer/NettyArrowBuf.java ## @@ -404,7 +407,7 @@ protected int _getUnsignedMediumLE(int index) {

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-16 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r440906089 ## File path: java/memory/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java ## @@ -31,19 +28,18 @@ public final long

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-16 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r440899130 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -78,6 +77,55 @@ public Object run() { Field addressField

[GitHub] [arrow] rymurr commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-16 Thread GitBox
rymurr commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r440896771 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -78,6 +77,55 @@ public Object run() { Field addressField