thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-841248102
> There are some file-read benchmarks that are >5% slower, interestingly it
is all (and only) the fanniemae dataset that is slower (both reading from
parquet and from
thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-841058739
> @thisisnic ooh we finally have some benchmark results to look at!:
[ursa-i9-9960x
thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-840595984
> Benchmark runs are scheduled for baseline =
[4e0f0cf](https://github.com/apache/arrow/commit/4e0f0cf79cf836a29e4bfd4a7b2d692f8b50bffe)
and contender =
thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-838628591
> This looks pretty good to me! Just a few final things:
>
> * Could you please ensure there are spaces added: `if(` → `if (` and
`){`→ `) {`
>
> * Could
thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-836325287
@ianmcook I think this is something for a separate ticket/PR, but when I was
testing things you mentioned above, I found that it is possible to create
`Table` and
thisisnic commented on pull request #10269:
URL: https://github.com/apache/arrow/pull/10269#issuecomment-836322644
> What happens if you pass data frames instead of vectors and one of them
has length one (i.e. only one row)? Maybe add a test to check the behavior in
that case.
Will
