[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-08-04 Thread GitBox
tianchen92 commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-668444768 > @tianchen92 would you mind starting a thread on the ML, it seems that @jacques-n might not have bandwidth. ok, started already.

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-07-16 Thread GitBox
tianchen92 commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-659219834 >My current understanding is there is a cycle here which needs to be broken (@tianchen92 please let me know if understand the issues correcty). @emkornfield sorry for

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-07-05 Thread GitBox
tianchen92 commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-654001963 > @tianchen92 does @jacques-n proposal make sense? >step 1 being deprecation and step 2 being removal Hmm, does this mean 1. leave old method in place with

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-06-30 Thread GitBox
tianchen92 commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-651706326 > Can we leave the old method in place and mark it as deprecated and remove in a later release? I am afraid it's not reasonable. since we need the right order in IPC and

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-06-27 Thread GitBox
tianchen92 commented on pull request #6156: URL: https://github.com/apache/arrow/pull/6156#issuecomment-650685609 > Does this impact IPC? seems not, IPC used getFieldBuffers which has the right buffer order, this PR is going to replace getFieldBuffers with getBuffers (getBuffers has