[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-08-04 Thread GitBox 


tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-668444768


   > @tianchen92 would you mind starting a thread on the ML, it seems that 
@jacques-n might not have bandwidth.
   
   ok, started already.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-07-16 Thread GitBox 


tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-659219834


   >My current understanding is there is a cycle here which needs to be broken 
(@tianchen92 please let me know if understand the issues correcty).
   
   @emkornfield sorry for the delay, your understanding is right :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-07-05 Thread GitBox 


tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-654001963


   > @tianchen92 does @jacques-n proposal make sense?
   
   >step 1 being deprecation and step 2 being removal
   
   Hmm, does this mean 
   1. leave old method in place with deprecation and add a new method(such as 
getBuffersNew) which should be used in IPC
   or
   2. totally revert this change and just mark getBuffers as deprecated
   ?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-06-30 Thread GitBox 


tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-651706326


   > Can we leave the old method in place and mark it as deprecated and remove 
in a later release?
   
   I am afraid it's not reasonable. since we need the right order in IPC and 
Dremio need the old wrong order in getBuffers to avoid test failure, unless we 
correct the behavior in getBuffers and rename the old method like getBuffers2 
which seems ugly . @projjal Any thought? :)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] tianchen92 commented on pull request #6156: ARROW-7539: [Java] FieldVector getFieldBuffers API should not set reader/writer indices

2020-06-27 Thread GitBox 


tianchen92 commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-650685609


   > Does this impact IPC?
   
   seems not, IPC used getFieldBuffers which has the right buffer order, this 
PR is going to replace getFieldBuffers with getBuffers (getBuffers has wrong 
buffer order witch will break Dremio tests)



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org