[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656912930 I'm fine with that. I'll try to find some time for it tomorrow. This is an automated message from the Apache Git

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656902745 > our build system does not select static libraries when using -DARROW_DEPENDENCY_SOURCE=SYSTEM This is not true. > only add static libraries to

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656887788 > Re: system dependencies and static build, is https://issues.apache.org/jira/browse/ARROW-6312 related? I encountered this issue in

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656880866 > We can't put the Arrow toolchain libraries in INTERFACE_LINK_LIBRARIES because they will be unrecognized by the third party project. I still think that

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656721257 From my testing: ``` -- All bundled static libraries: jemalloc::jemalloc;mimalloc::mimalloc -- Creating bundled static library target arrow_bundled_dependencies at

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656671314 Can you apply this patch to synchronize to mimalloc? ``` diff --git a/cmake_modules/ThirdpartyToolchain.cmake b/cmake_modules/ThirdpartyToolchain.cmake ---