trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r493767917
##
File path: js/package.json
##
@@ -100,11 +100,11 @@
"source-map-loader": "0.2.4",
"terser-webpack-plugin": "1.2.1",
"trash": "4.3.0",
-
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492263370
##
File path: js/src/interfaces.ts
##
@@ -356,48 +356,48 @@ type TypeToBuilder = {
/** @ignore */
type DataTypeToBuilder = {
-[key: number
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r493036448
##
File path: js/test/inference/column.ts
##
@@ -33,33 +33,6 @@ const boolColumn = new Column(new Field('bool', boolType), [
expect(typeof boolVector.get(
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r493036448
##
File path: js/test/inference/column.ts
##
@@ -33,33 +33,6 @@ const boolColumn = new Column(new Field('bool', boolType), [
expect(typeof boolVector.get(
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492260498
##
File path: .env
##
@@ -30,7 +30,7 @@ LLVM=10
CLANG_TOOLS=8
RUST=nightly-2020-04-22
GO=1.12
-NODE=11
+NODE=14
Review comment:
No we still work
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492264638
##
File path: js/test/inference/column.ts
##
@@ -33,33 +33,6 @@ const boolColumn = new Column(new Field('bool', boolType), [
expect(typeof boolVector.get(
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492263771
##
File path: js/test/Arrow.ts
##
@@ -27,6 +27,13 @@ require('web-stream-tools');
( global).window = ( global).window || global;
// Fix for Jest in nod
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492263370
##
File path: js/src/interfaces.ts
##
@@ -356,48 +356,48 @@ type TypeToBuilder = {
/** @ignore */
type DataTypeToBuilder = {
-[key: number
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492262537
##
File path: js/src/data.ts
##
@@ -253,11 +254,11 @@ export class Data {
return new Data(type, offset, length, nullCount, [undefined,
toArrayBuf
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492262029
##
File path: js/test/unit/ipc/helpers.ts
##
@@ -54,13 +54,13 @@ export abstract class ArrowIOTestHelper {
await testFn(await this.writer(this
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492260498
##
File path: .env
##
@@ -30,7 +30,7 @@ LLVM=10
CLANG_TOOLS=8
RUST=nightly-2020-04-22
GO=1.12
-NODE=11
+NODE=14
Review comment:
No we still work
11 matches
Mail list logo
