[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-23 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r563168268 ## File path: rust/arrow/src/array/array_string.rs ## @@ -50,49 +50,65 @@ pub struct GenericStringArray { } impl GenericStringArray { -/// Returns

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-23 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r563166348 ## File path: rust/arrow/src/array/array_string.rs ## @@ -50,49 +50,65 @@ pub struct GenericStringArray { } impl GenericStringArray { -/// Returns

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-22 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r563020240 ## File path: rust/arrow/src/array/array_primitive.rs ## @@ -86,13 +86,9 @@ impl PrimitiveArray { } /// Returns the primitive value at index

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-22 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r562999845 ## File path: rust/arrow/src/array/array_primitive.rs ## @@ -86,13 +86,9 @@ impl PrimitiveArray { } /// Returns the primitive value at index

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-21 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r562406187 ## File path: rust/arrow/src/array/array_primitive.rs ## @@ -86,13 +86,9 @@ impl PrimitiveArray { } /// Returns the primitive value at index

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-21 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r561918229 ## File path: rust/arrow/src/array/array_primitive.rs ## @@ -86,13 +86,9 @@ impl PrimitiveArray { } /// Returns the primitive value at index

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-21 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r561918229 ## File path: rust/arrow/src/array/array_primitive.rs ## @@ -86,13 +86,9 @@ impl PrimitiveArray { } /// Returns the primitive value at index

[GitHub] [arrow] tyrelr commented on a change in pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-21 Thread GitBox
tyrelr commented on a change in pull request #9215: URL: https://github.com/apache/arrow/pull/9215#discussion_r561918229 ## File path: rust/arrow/src/array/array_primitive.rs ## @@ -86,13 +86,9 @@ impl PrimitiveArray { } /// Returns the primitive value at index