[GitHub] [arrow] vertexclique commented on a change in pull request #7061: ARROW-8629: [Rust] Eliminate indirection of zero sized allocations

2020-05-02 Thread GitBox
vertexclique commented on a change in pull request #7061: URL: https://github.com/apache/arrow/pull/7061#discussion_r419000857 ## File path: rust/arrow/src/memory.rs ## @@ -20,34 +20,56 @@ use std::alloc::Layout; use std::mem::align_of; +use std::ptr::NonNull; pub const

[GitHub] [arrow] vertexclique commented on a change in pull request #7061: ARROW-8629: [Rust] Eliminate indirection of zero sized allocations

2020-05-02 Thread GitBox
vertexclique commented on a change in pull request #7061: URL: https://github.com/apache/arrow/pull/7061#discussion_r419000857 ## File path: rust/arrow/src/memory.rs ## @@ -20,34 +20,56 @@ use std::alloc::Layout; use std::mem::align_of; +use std::ptr::NonNull; pub const

[GitHub] [arrow] vertexclique commented on a change in pull request #7061: ARROW-8629: [Rust] Eliminate indirection of zero sized allocations

2020-05-02 Thread GitBox
vertexclique commented on a change in pull request #7061: URL: https://github.com/apache/arrow/pull/7061#discussion_r418999354 ## File path: rust/arrow/src/util/bit_util.rs ## @@ -148,11 +148,17 @@ pub fn count_set_bits_offset(data: &[u8], offset: usize, length: usize) ->

[GitHub] [arrow] vertexclique commented on a change in pull request #7061: ARROW-8629: [Rust] Eliminate indirection of zero sized allocations

2020-04-30 Thread GitBox
vertexclique commented on a change in pull request #7061: URL: https://github.com/apache/arrow/pull/7061#discussion_r417823393 ## File path: rust/arrow/src/memory.rs ## @@ -20,34 +20,56 @@ use std::alloc::Layout; use std::mem::align_of; +use std::ptr::NonNull; pub const