[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-17 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r441588468 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,107 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-16 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r441139760 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,107 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-16 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r441024436 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-16 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440952996 ## File path: cpp/src/arrow/testing/random.h ## @@ -250,6 +250,21 @@ class ARROW_EXPORT RandomArrayGenerator {

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-15 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r44024 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-15 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r440225706 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r439739768 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r439704017 ## File path: cpp/src/arrow/compute/kernels/scalar_validity_test.cc ## @@ -0,0 +1,151 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r439703255 ## File path: cpp/src/arrow/testing/random.h ## @@ -250,6 +250,9 @@ class ARROW_EXPORT RandomArrayGenerator {

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r439703006 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.h ## @@ -181,8 +180,7 @@ struct GetOutputType> { }; template -struct GetOutputType< -

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-11 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r439108275 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.h ## @@ -181,8 +180,7 @@ struct GetOutputType> { }; template -struct GetOutputType< -