[GitHub] [arrow] wesm commented on a change in pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7417: URL: https://github.com/apache/arrow/pull/7417#discussion_r439765330 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc ## @@ -67,89 +68,35 @@ static void ArrayArrayKernel(benchmark::State& state) {

[GitHub] [arrow] wesm commented on a change in pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7417: URL: https://github.com/apache/arrow/pull/7417#discussion_r439765195 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] wesm commented on a change in pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7417: URL: https://github.com/apache/arrow/pull/7417#discussion_r439431785 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one