[GitHub] [arrow] wesm commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439765677 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +39,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the

[GitHub] [arrow] wesm commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439755593 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +39,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the

[GitHub] [arrow] wesm commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439451091 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +39,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the

[GitHub] [arrow] wesm commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-12 Thread GitBox
wesm commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439418114 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +37,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the