[GitHub] [arrow] wesm commented on a change in pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-03 Thread GitBox
wesm commented on a change in pull request #7593: URL: https://github.com/apache/arrow/pull/7593#discussion_r449553297 ## File path: cpp/src/arrow/compute/kernels/scalar_string_benchmark.cc ## @@ -56,6 +57,11 @@ static void AsciiUpper(benchmark::State& state) {

[GitHub] [arrow] wesm commented on a change in pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm commented on a change in pull request #7593: URL: https://github.com/apache/arrow/pull/7593#discussion_r447982219 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -387,16 +380,20 @@ using ContainsExactState = OptionsWrapper; template struct