[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453084856 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453081425 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453079515 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r452946143 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on