[GitHub] [arrow] wesm commented on issue #6986: ARROW-8523: [C++] Optimize BitmapReader

2020-04-21 Thread GitBox
wesm commented on issue #6986: URL: https://github.com/apache/arrow/pull/6986#issuecomment-617228774 FWIW, we have some benchmark diffing code already written in https://github.com/apache/arrow/blob/master/dev/archery/archery/benchmark I'm not sure where this is documented /

[GitHub] [arrow] wesm commented on issue #6986: ARROW-8523: [C++] Optimize BitmapReader

2020-04-21 Thread GitBox
wesm commented on issue #6986: URL: https://github.com/apache/arrow/pull/6986#issuecomment-617150324 In the meantime, when we have microperformance patches like these it would be a good practice in the future to make sure that performance results are reproduced in the codebase's benchmark

[GitHub] [arrow] wesm commented on issue #6986: ARROW-8523: [C++] Optimize BitmapReader

2020-04-21 Thread GitBox
wesm commented on issue #6986: URL: https://github.com/apache/arrow/pull/6986#issuecomment-617149608 > BTW: we definitely need continuous benchmark tools to detect these things early. Agreed. Hopefully some progress can be made on this in 2020 since the prior discussion in 2019

[GitHub] [arrow] wesm commented on issue #6986: ARROW-8523: [C++] Optimize BitmapReader

2020-04-20 Thread GitBox
wesm commented on issue #6986: URL: https://github.com/apache/arrow/pull/6986#issuecomment-616536379 Cool, nice improvement This is an automated message from the Apache Git Service. To respond to the message, please log on