[GitHub] [arrow] wesm commented on pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-16 Thread GitBox 


wesm commented on pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#issuecomment-645034827


   Merging



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-16 Thread GitBox 


wesm commented on pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#issuecomment-645011421


   @bkietz if you want to disable the ascii_* tests that are failing please go 
ahead



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-12 Thread GitBox 


wesm commented on pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#issuecomment-643560679


   I'm not thrilled about the testing mixin. Can we split all that out into a 
separate PR (if at all, will see what @pitrou thinks about it) so that these 
kernels are not held hostage over it? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-12 Thread GitBox 


wesm commented on pull request #7410:
URL: https://github.com/apache/arrow/pull/7410#issuecomment-643558658


   I rebased after fixing the linting issue ARROW-9120



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org