[GitHub] [arrow] wesm commented on pull request #7459: ARROW-6800: [C++] Support building libraries targeting C++14 or higher, disable GNU CXX extensions

2020-06-16 Thread GitBox
wesm commented on pull request #7459: URL: https://github.com/apache/arrow/pull/7459#issuecomment-645049112 OK I guess I'm a bit out of my depth on the CMAKE_CXX_EXTENSIONS issue. If anyone has ideas about what to do let me know

[GitHub] [arrow] wesm commented on pull request #7459: ARROW-6800: [C++] Support building libraries targeting C++14 or higher, disable GNU CXX extensions

2020-06-16 Thread GitBox
wesm commented on pull request #7459: URL: https://github.com/apache/arrow/pull/7459#issuecomment-645047309 Well this is weird ``` CMake Error in src/plasma/CMakeLists.txt: Target "plasma-external-store-tests" requires the language dialect "CXXOFF" , but CMake does not

[GitHub] [arrow] wesm commented on pull request #7459: ARROW-6800: [C++] Support building libraries targeting C++14 or higher, disable GNU CXX extensions

2020-06-16 Thread GitBox
wesm commented on pull request #7459: URL: https://github.com/apache/arrow/pull/7459#issuecomment-645047223 @kou @brills @kszucs could use your advice on possible concerns regarding the -std=gnu++11 to -std=c++11 change when using gcc