[GitHub] [arrow] wesm commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-07-12 Thread GitBox 


wesm commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-657343188


   Yes you need to use the `--gold-dirs` argument



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-07-12 Thread GitBox 


wesm commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-657282736


   I was suggesting to generate BE and LE files to be put in this directory
   
   
https://github.com/apache/arrow-testing/tree/master/data/arrow-ipc-stream/integration
   
   Then you can specify the respective directory of e.g. BE files to be read on 
an LE platform
   
   I think it's better to stick with the integration test tools for this rather 
than writing new C++ code



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] wesm commented on pull request #7507: ARROW-8797: [C++] Create test to receive RecordBatch for different endian

2020-06-30 Thread GitBox 


wesm commented on pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#issuecomment-652142541


   @kiszk I would suggest creating a LE and BE example corpus in 
apache/arrow-testing. You can use the integration test command line tools to 
create point-of-truth JSON files and then use the JSON_TO_ARROW mode of the 
integration test executable to create IPC binary files that can be checked in 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org