[GitHub] [arrow] wesm commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

wesm commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649911719 Okay, thanks. I think we can leave it as is This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] wesm commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

wesm commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649849609 +1, merging this. If removing the BitmapReader helps perf it can be done in a follow up PR This is an automated mess

[GitHub] [arrow] wesm commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

wesm commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649548830 @jianxind I think the bot is broken right now because of the changes I recently made in ARROW-9201. @kszucs is going to update it ---

[GitHub] [arrow] wesm commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

wesm commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649067717 Benchmark results ``` $ archery benchmark diff --cc=gcc-8 --cxx=g++-8 jianxind/BitBlockSpaced master --suite-filter=parquet-encoding