[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-29 Thread GitBox


wesm commented on pull request #7571:
URL: https://github.com/apache/arrow/pull/7571#issuecomment-651351599


   I'll close this for now. Please leave any review comments and I can address 
them later



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-29 Thread GitBox


wesm commented on pull request #7571:
URL: https://github.com/apache/arrow/pull/7571#issuecomment-651146389


   @pitrou this is already merged (by accident actually, mistyped the PR number 
on the command line and went too fast), but let me know if you see anything 
concerning from a fuzz perspective or otherwise. I fixed one fuzz issue already 
in 
https://github.com/apache/arrow/commit/76c3e4a6d30e279fa5707f7cc14e8aacf00f08a3



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox


wesm commented on pull request #7571:
URL: https://github.com/apache/arrow/pull/7571#issuecomment-650857082


   This has an ASAN/UBSAN failure. I will fix within an hour



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox


wesm commented on pull request #7571:
URL: https://github.com/apache/arrow/pull/7571#issuecomment-650830163


   Oops, I didn't mean to merge this patch, sorry! Please review it and I will 
address any code reviews as follow up



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox


wesm commented on pull request #7571:
URL: https://github.com/apache/arrow/pull/7571#issuecomment-650829722


   I confirmed that I can read compressed files (including compressed 
dictionaries) generated from master



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org