[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-02 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-653042125 OK, do you have an idea for a prefix for a function that works either on BinaryArray or StringArray? This could also be handled with aliases so we could have `utf8_contains_ex

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". ~~I'm pushing that change here shortly~~. Or should we call it "binary_contains" / "string_cont

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". ~~I'm pushing that change here shortly~~. Or should we call it "binary_contains" / "string_cont

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". ~~I'm pushing that change here shortly~~. Or should we call it "binary_contains" / "string_cont

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". I'm pushing that change here shortly. Or should we call it "BinaryContains" since it will work

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652053744 I also propose to rename the function from "contains_exact" to "utf8_contains". I'm pushing that change here shortly. Or should we call it "binary_contains" / "string_contains

[GitHub] [arrow] wesm edited a comment on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
wesm edited a comment on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651849432 @xhochy chunked arrays should be handled automatically by the function executors. I will take a look. This i