[GitHub] [arrow] xhochy commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-03 Thread GitBox
xhochy commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-653379639 Adressed all comments and CI is happy, too. This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] xhochy commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-01 Thread GitBox
xhochy commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652244376 > You match a regex, you don't contain it. That is one of the name clashes, we already have a match kernel.

[GitHub] [arrow] xhochy commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
xhochy commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652195053 I think prefixes make sense. We will have sometime similar kernel names that act quite different depending on the types they work on. I would differentiate in the string/binary

[GitHub] [arrow] xhochy commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-06-30 Thread GitBox
xhochy commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-651779867 This currently fails for chunked arrays. I though that they should be handled by the kernel framework automatically but it seems, they aren't. ``` [--] 1 test