[GitHub] [arrow] zgramana commented on pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

zgramana commented on pull request #7032: URL: https://github.com/apache/arrow/pull/7032#issuecomment-624165014 @mr-smidge That sounds great. I used `BooleanArray` two reasons: because it already provided the needed behavior, and because I had to move pretty fast. ;-)

[GitHub] [arrow] zgramana commented on pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

zgramana commented on pull request #7032: URL: https://github.com/apache/arrow/pull/7032#issuecomment-622566445 Thanks @eerhardt. This was a great introduction into the internals, and happy I could contribute back something useful. -

[GitHub] [arrow] zgramana commented on pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

zgramana commented on pull request #7032: URL: https://github.com/apache/arrow/pull/7032#issuecomment-622217498 @eerhardt I think I covered everything. I also discovered that I had omitted adding `null` support to `ListArray.Builder` so I added that too (including test coverage) in the spi

[GitHub] [arrow] zgramana commented on pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

zgramana commented on pull request #7032: URL: https://github.com/apache/arrow/pull/7032#issuecomment-620266004 @eerhardt thanks for the excellent review and feedback. I believe that I have pushed fixes for everything. I also noticed I had missed validity buffer state management in