[GitHub] [arrow-rs] alamb commented on a change in pull request #443: parquet: improve BOOLEAN writing logic and report error on encoding fail

2021-06-14 Thread GitBox
alamb commented on a change in pull request #443: URL: https://github.com/apache/arrow-rs/pull/443#discussion_r651058305 ## File path: parquet/tests/boolean_writer.rs ## @@ -0,0 +1,100 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow-rs] alamb commented on a change in pull request #443: parquet: improve BOOLEAN writing logic and report error on encoding fail

2021-06-14 Thread GitBox
alamb commented on a change in pull request #443: URL: https://github.com/apache/arrow-rs/pull/443#discussion_r650959936 ## File path: parquet/src/data_type.rs ## @@ -661,8 +661,15 @@ pub(crate) mod private { _: W, bit_writer: BitWriter, )

[GitHub] [arrow-rs] alamb commented on a change in pull request #443: parquet: improve BOOLEAN writing logic and report error on encoding fail

2021-06-14 Thread GitBox
alamb commented on a change in pull request #443: URL: https://github.com/apache/arrow-rs/pull/443#discussion_r650505824 ## File path: parquet/src/data_type.rs ## @@ -661,8 +661,15 @@ pub(crate) mod private { _: W, bit_writer: BitWriter, )