[GitHub] [arrow-rs] jhorstmann commented on pull request #389: make slice work for nested types

2021-07-11 Thread GitBox
jhorstmann commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-877864847 This looks good and makes sense to me. StructArray (and probably union too) are a bit of a special case in how offsets are propagated. Since we currently do not push down

[GitHub] [arrow-rs] jhorstmann commented on pull request #389: make slice work for nested types

2021-06-06 Thread GitBox
jhorstmann commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-855363485 @nevi-me can you point me to a testcase and does this only involve arrow or the parquet roundtrip? I'd be happy to take a look. My thoughts are that a `List` is basically the

[GitHub] [arrow-rs] jhorstmann commented on pull request #389: make slice work for nested types

2021-06-02 Thread GitBox
jhorstmann commented on pull request #389: URL: https://github.com/apache/arrow-rs/pull/389#issuecomment-852871638 I think instead of switching of child_data.is_empty we rather need a special case for struct and union types. ListArray for example should work fine with the current logic.