[GitHub] [beam] chamikaramj commented on pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11039: URL: https://github.com/apache/beam/pull/11039#issuecomment-630584744 Heejong, can you please resolve conflicts and push an update to rerun tests ? This is an automated message

[GitHub] [beam] stale[bot] commented on pull request #10509: RabbitMq IO Connector Refactor + Bugfixes

2020-05-18 Thread GitBox
stale[bot] commented on pull request #10509: URL: https://github.com/apache/beam/pull/10509#issuecomment-630578159 This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull

[GitHub] [beam] amaliujia commented on pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
amaliujia commented on pull request #11737: URL: https://github.com/apache/beam/pull/11737#issuecomment-630577035 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia merged pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
amaliujia merged pull request #10946: URL: https://github.com/apache/beam/pull/10946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] chamikaramj commented on pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11740: URL: https://github.com/apache/beam/pull/11740#issuecomment-630562942 Tests passed. PTAL. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] henryken commented on pull request #11736: Katas - Convert task description from HTML to Markdown

2020-05-18 Thread GitBox
henryken commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-630553569 @pabloem, this pull request can now be merged. This is an automated message from the Apache Git Service. To

[GitHub] [beam] henryken commented on pull request #11736: Katas - Convert task description from HTML to Markdown

2020-05-18 Thread GitBox
henryken commented on pull request #11736: URL: https://github.com/apache/beam/pull/11736#issuecomment-630553094 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik commented on a change in pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
lukecwik commented on a change in pull request #11748: URL: https://github.com/apache/beam/pull/11748#discussion_r427005013 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java ## @@ -183,7 +183,10 @@

[GitHub] [beam] lukecwik merged pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
lukecwik merged pull request #11748: URL: https://github.com/apache/beam/pull/11748 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] youngoli commented on a change in pull request #11747: [BEAM-9951] Using the builder pattern for Go synthetic config frontend

2020-05-18 Thread GitBox
youngoli commented on a change in pull request #11747: URL: https://github.com/apache/beam/pull/11747#discussion_r427004634 ## File path: sdks/go/pkg/beam/io/synthetic/step.go ## @@ -144,49 +143,130 @@ func (fn *sdfStepFn) Setup() { // ProcessElement takes an input and either

[GitHub] [beam] youngoli commented on a change in pull request #11747: [BEAM-9951] Using the builder pattern for Go synthetic config frontend

2020-05-18 Thread GitBox
youngoli commented on a change in pull request #11747: URL: https://github.com/apache/beam/pull/11747#discussion_r427004608 ## File path: sdks/go/pkg/beam/io/synthetic/source.go ## @@ -135,27 +155,79 @@ func (fn *sourceFn) ProcessElement(rt *offsetrange.Tracker, config

[GitHub] [beam] suztomo commented on pull request #11674: [BEAM-9958] Linkage Checker to use exclusion files as baseline

2020-05-18 Thread GitBox
suztomo commented on pull request #11674: URL: https://github.com/apache/beam/pull/11674#issuecomment-630549911 No test for this scripts. With this PR, we can setup a Jenkins task to run the Linkage Checker, say, "Run Java LinkageChecker".

[GitHub] [beam] amaliujia commented on pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
amaliujia commented on pull request #10946: URL: https://github.com/apache/beam/pull/10946#issuecomment-630548345 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] damondouglas commented on a change in pull request #11734: [BEAM-9679] Add Core Transforms section / GroupByKey lesson to the Go SDK katas

2020-05-18 Thread GitBox
damondouglas commented on a change in pull request #11734: URL: https://github.com/apache/beam/pull/11734#discussion_r426996114 ## File path: learning/katas/go/Core Transforms/GroupByKey/GroupByKey/task.md ## @@ -0,0 +1,50 @@ + + +# GroupByKey + +GroupByKey is a Beam transform

[GitHub] [beam] damondouglas commented on a change in pull request #11734: [BEAM-9679] Add Core Transforms section / GroupByKey lesson to the Go SDK katas

2020-05-18 Thread GitBox
damondouglas commented on a change in pull request #11734: URL: https://github.com/apache/beam/pull/11734#discussion_r426996114 ## File path: learning/katas/go/Core Transforms/GroupByKey/GroupByKey/task.md ## @@ -0,0 +1,50 @@ + + +# GroupByKey + +GroupByKey is a Beam transform

[GitHub] [beam] boyuanzz opened a new pull request #11749: [WIP, DO NOT REVIEW PLEASE] Implement ReadFromKafkaViaSDF

2020-05-18 Thread GitBox
boyuanzz opened a new pull request #11749: URL: https://github.com/apache/beam/pull/11749 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] boyuanzz commented on pull request #11715: [BEAM-9977] Implement GrowableOffsetRangeTracker

2020-05-18 Thread GitBox
boyuanzz commented on pull request #11715: URL: https://github.com/apache/beam/pull/11715#issuecomment-630536199 Latest changes are for addressing comments and using double during computation. @lukecwik PTAL. Thanks for your help!

[GitHub] [beam] TheNeuralBit merged pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
TheNeuralBit merged pull request #11528: URL: https://github.com/apache/beam/pull/11528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] robertwb commented on a change in pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
robertwb commented on a change in pull request #11748: URL: https://github.com/apache/beam/pull/11748#discussion_r426974286 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java ## @@ -183,7 +183,10 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
lukecwik commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426974548 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java ## @@ -53,9 +53,12

[GitHub] [beam] apilloud commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
apilloud commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426974365 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/TVFStreamingUtils.java ## @@ -0,0 +1,24 @@ +/* + *

[GitHub] [beam] lukecwik commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
lukecwik commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426973945 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -784,7 +877,25 @@ public

[GitHub] [beam] lukecwik commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
lukecwik commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426973945 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java ## @@ -784,7 +877,25 @@ public

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426971999 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java ## @@ -195,7 +187,7 @@ public void

[GitHub] [beam] lukecwik commented on pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
lukecwik commented on pull request #11748: URL: https://github.com/apache/beam/pull/11748#issuecomment-630514195 CC: @ananvay This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] lukecwik edited a comment on pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
lukecwik edited a comment on pull request #11748: URL: https://github.com/apache/beam/pull/11748#issuecomment-630514089 R: @ihji @robertwb This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] lukecwik opened a new pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
lukecwik opened a new pull request #11748: URL: https://github.com/apache/beam/pull/11748 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose

[GitHub] [beam] lukecwik commented on pull request #11748: [BEAM-9339] Ensure that Dataflow's pipeline proto also contains the capabilities

2020-05-18 Thread GitBox
lukecwik commented on pull request #11748: URL: https://github.com/apache/beam/pull/11748#issuecomment-630514089 R: @y1chi @robertwb This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426969362 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,162 @@ +/*

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426968398 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -175,6 +185,37 @@

[GitHub] [beam] aaltay commented on pull request #11674: [BEAM-9958] Linkage Checker to use exclusion files as baseline

2020-05-18 Thread GitBox
aaltay commented on pull request #11674: URL: https://github.com/apache/beam/pull/11674#issuecomment-630510006 Running the tests. Does any test, actually test this code? This is an automated message from the Apache Git

[GitHub] [beam] aaltay commented on pull request #11437: [BEAM-9770] Add BigQueryIO deadletter pattern

2020-05-18 Thread GitBox
aaltay commented on pull request #11437: URL: https://github.com/apache/beam/pull/11437#issuecomment-630510056 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] aaltay commented on pull request #11674: [BEAM-9958] Linkage Checker to use exclusion files as baseline

2020-05-18 Thread GitBox
aaltay commented on pull request #11674: URL: https://github.com/apache/beam/pull/11674#issuecomment-630509865 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426967410 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/TVFStreamingUtils.java ## @@ -0,0 +1,24 @@ +/* + *

[GitHub] [beam] amaliujia commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426966749 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java ## @@ -0,0 +1,162 @@ +/*

[GitHub] [beam] apilloud commented on a change in pull request #10946: [BEAM-9363] TUMBLE as TVF

2020-05-18 Thread GitBox
apilloud commented on a change in pull request #10946: URL: https://github.com/apache/beam/pull/10946#discussion_r426949818 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java ## @@ -0,0

[GitHub] [beam] TheNeuralBit commented on pull request #11532: [BEAM-9822] Disable grouping when streaming

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11532: URL: https://github.com/apache/beam/pull/11532#issuecomment-630495848 Looks like you need to run spotless to auto-format. You can use `./gradlew spotlessApply` to do that locally (may need to do it on the other PRs as well)

[GitHub] [beam] TheNeuralBit commented on pull request #11570: [BEAM-9822] Merge the stages 'Gather and Sort' and 'Create Batches'

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11570: URL: https://github.com/apache/beam/pull/11570#issuecomment-630495763 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11529: [BEAM-9822] Simplify pipeline when batching is disabled.

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11529: URL: https://github.com/apache/beam/pull/11529#issuecomment-630495233 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11528: URL: https://github.com/apache/beam/pull/11528#issuecomment-630494999 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11532: [BEAM-9822] Disable grouping when streaming

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11532: URL: https://github.com/apache/beam/pull/11532#issuecomment-630494893 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] TheNeuralBit commented on pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11528: URL: https://github.com/apache/beam/pull/11528#issuecomment-630494783 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nielm removed a comment on pull request #11532: [BEAM-9822] Disable grouping when streaming

2020-05-18 Thread GitBox
nielm removed a comment on pull request #11532: URL: https://github.com/apache/beam/pull/11532#issuecomment-630472990 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nielm commented on pull request #11532: [BEAM-9822] Disable grouping when streaming

2020-05-18 Thread GitBox
nielm commented on pull request #11532: URL: https://github.com/apache/beam/pull/11532#issuecomment-630492055 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] nielm commented on pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
nielm commented on pull request #11528: URL: https://github.com/apache/beam/pull/11528#issuecomment-630492150 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] nielm removed a comment on pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
nielm removed a comment on pull request #11528: URL: https://github.com/apache/beam/pull/11528#issuecomment-630469413 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nielm removed a comment on pull request #11529: [BEAM-9822] Simplify pipeline when batching is disabled.

2020-05-18 Thread GitBox
nielm removed a comment on pull request #11529: URL: https://github.com/apache/beam/pull/11529#issuecomment-630476722 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nielm commented on pull request #11529: [BEAM-9822] Simplify pipeline when batching is disabled.

2020-05-18 Thread GitBox
nielm commented on pull request #11529: URL: https://github.com/apache/beam/pull/11529#issuecomment-630491891 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] nielm commented on pull request #11570: [BEAM-9822] Merge the stages 'Gather and Sort' and 'Create Batches'

2020-05-18 Thread GitBox
nielm commented on pull request #11570: URL: https://github.com/apache/beam/pull/11570#issuecomment-630491802 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] nielm commented on a change in pull request #11570: [BEAM-9822] Merge the stages 'Gather and Sort' and 'Create Batches'

2020-05-18 Thread GitBox
nielm commented on a change in pull request #11570: URL: https://github.com/apache/beam/pull/11570#discussion_r426947630 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java ## @@ -1171,67 +1145,127 @@ public void

[GitHub] [beam] nielm commented on pull request #11570: [BEAM-9822] Merge the stages 'Gather and Sort' and 'Create Batches'

2020-05-18 Thread GitBox
nielm commented on pull request #11570: URL: https://github.com/apache/beam/pull/11570#issuecomment-630488670 @allenpradeep > 1. What mode should our import pipeline use? Should it use option b as data in AVRO seems already sorted? We can discuss this outside the scope of this

[GitHub] [beam] chamikaramj commented on pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11039: URL: https://github.com/apache/beam/pull/11039#issuecomment-630487229 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lostluck commented on a change in pull request #11747: [BEAM-9951] Using the builder pattern for Go synthetic config frontend

2020-05-18 Thread GitBox
lostluck commented on a change in pull request #11747: URL: https://github.com/apache/beam/pull/11747#discussion_r426935903 ## File path: sdks/go/pkg/beam/io/synthetic/source.go ## @@ -135,27 +155,79 @@ func (fn *sourceFn) ProcessElement(rt *offsetrange.Tracker, config

[GitHub] [beam] tysonjh commented on a change in pull request #11566: [BEAM-9723] Add DLP integration transforms

2020-05-18 Thread GitBox
tysonjh commented on a change in pull request #11566: URL: https://github.com/apache/beam/pull/11566#discussion_r426831619 ## File path: sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java ## @@ -0,0 +1,101 @@ +/* + * Licensed to

[GitHub] [beam] omarismail94 commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
omarismail94 commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426935461 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java ## @@ -347,4

[GitHub] [beam] nielm commented on pull request #11529: [BEAM-9822] Simplify pipeline when batching is disabled.

2020-05-18 Thread GitBox
nielm commented on pull request #11529: URL: https://github.com/apache/beam/pull/11529#issuecomment-630476722 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] omarismail94 commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
omarismail94 commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426931476 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java ## @@ -347,4

[GitHub] [beam] nielm commented on pull request #11532: [BEAM-9822] Disable grouping when streaming

2020-05-18 Thread GitBox
nielm commented on pull request #11532: URL: https://github.com/apache/beam/pull/11532#issuecomment-630472990 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] robertwb merged pull request #11708: [BEAM-9577] Artifact v2 support for uber jars.

2020-05-18 Thread GitBox
robertwb merged pull request #11708: URL: https://github.com/apache/beam/pull/11708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] nielm commented on a change in pull request #11532: [BEAM-9822] Disable grouping when streaming

2020-05-18 Thread GitBox
nielm commented on a change in pull request #11532: URL: https://github.com/apache/beam/pull/11532#discussion_r426929817 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java ## @@ -1066,7 +1079,12 @@ public

[GitHub] [beam] TheNeuralBit commented on pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
TheNeuralBit commented on pull request #11528: URL: https://github.com/apache/beam/pull/11528#issuecomment-630470331 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] suztomo commented on a change in pull request #11674: [BEAM-9958] Linkage Checker to use exclusion files as baseline

2020-05-18 Thread GitBox
suztomo commented on a change in pull request #11674: URL: https://github.com/apache/beam/pull/11674#discussion_r426927838 ## File path: sdks/java/build-tools/beam-linkage-check.sh ## @@ -66,51 +66,61 @@ if [ ! -z "$(git diff)" ]; then exit 1 fi +ACCUMULATED_RESULT=0 +

[GitHub] [beam] suztomo commented on pull request #11674: [BEAM-9958] Linkage Checker to use exclusion files as baseline

2020-05-18 Thread GitBox
suztomo commented on pull request #11674: URL: https://github.com/apache/beam/pull/11674#issuecomment-630470049 @aaltay Thank you for taking review. PTAL. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] nielm commented on pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
nielm commented on pull request #11528: URL: https://github.com/apache/beam/pull/11528#issuecomment-630469413 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] nielm commented on a change in pull request #11528: [BEAM-9821] Populate all SpannerIO batching parameters in display data.

2020-05-18 Thread GitBox
nielm commented on a change in pull request #11528: URL: https://github.com/apache/beam/pull/11528#discussion_r426926639 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java ## @@ -991,6 +1001,24 @@ public

[GitHub] [beam] ihji commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
ihji commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426924859 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java ## @@ -195,7 +187,7 @@ public void

[GitHub] [beam] chamikaramj commented on pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11039: URL: https://github.com/apache/beam/pull/11039#issuecomment-630465449 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11039: URL: https://github.com/apache/beam/pull/11039#issuecomment-630465362 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11740: URL: https://github.com/apache/beam/pull/11740#issuecomment-630462316 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] youngoli commented on pull request #11747: [BEAM-9951] Using the builder pattern for Go synthetic config frontend

2020-05-18 Thread GitBox
youngoli commented on pull request #11747: URL: https://github.com/apache/beam/pull/11747#issuecomment-630460354 R: @lostluck This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] youngoli opened a new pull request #11747: [BEAM-9951] Using the builder pattern for Go synthetic config frontend

2020-05-18 Thread GitBox
youngoli opened a new pull request #11747: URL: https://github.com/apache/beam/pull/11747 Instead of just creating SourceConfigs and StepConfigs, have a builder pattern to allow more user-friendly creation of those configs with defaults. Thank

[GitHub] [beam] omarismail94 commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
omarismail94 commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426918300 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -4500,6

[GitHub] [beam] omarismail94 commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
omarismail94 commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426918114 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -2836,7

[GitHub] [beam] omarismail94 commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
omarismail94 commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426918047 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java ## @@ -171,10

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630455763 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11740: URL: https://github.com/apache/beam/pull/11740#issuecomment-630445775 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #11740: [BEAM-8019] Prevent Dataflow from starting multiple containers for the same image

2020-05-18 Thread GitBox
chamikaramj commented on pull request #11740: URL: https://github.com/apache/beam/pull/11740#issuecomment-630445694 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik opened a new pull request #11746: [BEAM-10028] Add support for the state backed iterable coder to the Java SDK harness.

2020-05-18 Thread GitBox
lukecwik opened a new pull request #11746: URL: https://github.com/apache/beam/pull/11746 This required supporting a translation context through CoderTranslator to give access to the BeamFnStateClient and current process bundle instruction id. Thank

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630440098 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] apilloud merged pull request #11272: [BEAM-9641] Support ZetaSQL DATE type as a Beam LogicalType

2020-05-18 Thread GitBox
apilloud merged pull request #11272: URL: https://github.com/apache/beam/pull/11272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630433535 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] aaltay commented on pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-05-18 Thread GitBox
aaltay commented on pull request #11075: URL: https://github.com/apache/beam/pull/11075#issuecomment-630432367 /cc @vilobhmm This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] aaltay commented on a change in pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-05-18 Thread GitBox
aaltay commented on a change in pull request #11075: URL: https://github.com/apache/beam/pull/11075#discussion_r426889254 ## File path: website/www/site/content/en/documentation/patterns/ai-platform.md ## @@ -0,0 +1,79 @@ +--- +title: "AI Platform integration patterns" +--- +

[GitHub] [beam] aaltay commented on pull request #11075: [BEAM-9421] Website section that describes getting predictions using AI Platform Prediciton

2020-05-18 Thread GitBox
aaltay commented on pull request #11075: URL: https://github.com/apache/beam/pull/11075#issuecomment-630430689 @kamilwu -- @katsiapis had a few questions. Please do not merge yet, I will add his comments here. This is an

[GitHub] [beam] robertwb commented on a change in pull request #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-05-18 Thread GitBox
robertwb commented on a change in pull request #11039: URL: https://github.com/apache/beam/pull/11039#discussion_r426876833 ## File path: runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java ## @@ -195,7 +187,7 @@ public

[GitHub] [beam] suztomo commented on a change in pull request #11674: [BEAM-9958] Linkage Checker to use exclusion files as baseline

2020-05-18 Thread GitBox
suztomo commented on a change in pull request #11674: URL: https://github.com/apache/beam/pull/11674#discussion_r426871194 ## File path: sdks/java/build-tools/beam-linkage-check.sh ## @@ -66,51 +66,61 @@ if [ ! -z "$(git diff)" ]; then exit 1 fi +ACCUMULATED_RESULT=0 +

[GitHub] [beam] rohdesamuel commented on pull request #11745: Add to/from_runner_api_parameters to WriteToBigQuery

2020-05-18 Thread GitBox
rohdesamuel commented on pull request #11745: URL: https://github.com/apache/beam/pull/11745#issuecomment-630412286 R: @robertwb can you take a look please? This is an automated message from the Apache Git Service. To

[GitHub] [beam] rohdesamuel opened a new pull request #11745: Add to/from_runner_api_parameters to WriteToBigQuery

2020-05-18 Thread GitBox
rohdesamuel opened a new pull request #11745: URL: https://github.com/apache/beam/pull/11745 Change-Id: Ifd969174d5a7744766173f35fd6b65a72ebfd924 The WriteToBigQuery only has a default implementation which can't reconstruct the original WriteToBigQuery.

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630408509 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] reuvenlax commented on pull request #11350: [BEAM-1589] Added @OnWindowExpiration annotation.

2020-05-18 Thread GitBox
reuvenlax commented on pull request #11350: URL: https://github.com/apache/beam/pull/11350#issuecomment-630407268 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630406503 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630406334 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] amaliujia commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426859494 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java ## @@ -347,4

[GitHub] [beam] amaliujia commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426859930 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -4500,6

[GitHub] [beam] amaliujia commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426859706 ## File path: sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java ## @@ -2836,7

[GitHub] [beam] iht commented on pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

2020-05-18 Thread GitBox
iht commented on pull request #11731: URL: https://github.com/apache/beam/pull/11731#issuecomment-630401560 Thank you! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] amaliujia commented on a change in pull request #11737: [BEAM-9984] Support BIT_OR aggregation function in Beam SQL

2020-05-18 Thread GitBox
amaliujia commented on a change in pull request #11737: URL: https://github.com/apache/beam/pull/11737#discussion_r426856451 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java ## @@ -171,10

[GitHub] [beam] TheNeuralBit opened a new pull request #11744: [BEAM-10007] Handle ValueProvider pipeline options in PortableRunner

2020-05-18 Thread GitBox
TheNeuralBit opened a new pull request #11744: URL: https://github.com/apache/beam/pull/11744 R: @aaltay Post-Commit Tests Status (on master branch) Lang | SDK | Apex |

[GitHub] [beam] TheNeuralBit merged pull request #11743: [BEAM-9964] Update CHANGES.md

2020-05-18 Thread GitBox
TheNeuralBit merged pull request #11743: URL: https://github.com/apache/beam/pull/11743 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [beam] pabloem commented on pull request #11339: [BEAM-9468] Fhir io

2020-05-18 Thread GitBox
pabloem commented on pull request #11339: URL: https://github.com/apache/beam/pull/11339#issuecomment-630391792 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >