chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-630584744
Heejong, can you please resolve conflicts and push an update to rerun tests ?
This is an automated message
stale[bot] commented on pull request #10509:
URL: https://github.com/apache/beam/pull/10509#issuecomment-630578159
This pull request has been marked as stale due to 60 days of inactivity. It
will be closed in 1 week if no further activity occurs. If you think that’s
incorrect or this pull
amaliujia commented on pull request #11737:
URL: https://github.com/apache/beam/pull/11737#issuecomment-630577035
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia merged pull request #10946:
URL: https://github.com/apache/beam/pull/10946
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chamikaramj commented on pull request #11740:
URL: https://github.com/apache/beam/pull/11740#issuecomment-630562942
Tests passed. PTAL.
This is an automated message from the Apache Git Service.
To respond to the message,
henryken commented on pull request #11736:
URL: https://github.com/apache/beam/pull/11736#issuecomment-630553569
@pabloem, this pull request can now be merged.
This is an automated message from the Apache Git Service.
To
henryken commented on pull request #11736:
URL: https://github.com/apache/beam/pull/11736#issuecomment-630553094
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik commented on a change in pull request #11748:
URL: https://github.com/apache/beam/pull/11748#discussion_r427005013
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##
@@ -183,7 +183,10 @@
lukecwik merged pull request #11748:
URL: https://github.com/apache/beam/pull/11748
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
youngoli commented on a change in pull request #11747:
URL: https://github.com/apache/beam/pull/11747#discussion_r427004634
##
File path: sdks/go/pkg/beam/io/synthetic/step.go
##
@@ -144,49 +143,130 @@ func (fn *sdfStepFn) Setup() {
// ProcessElement takes an input and either
youngoli commented on a change in pull request #11747:
URL: https://github.com/apache/beam/pull/11747#discussion_r427004608
##
File path: sdks/go/pkg/beam/io/synthetic/source.go
##
@@ -135,27 +155,79 @@ func (fn *sourceFn) ProcessElement(rt
*offsetrange.Tracker, config
suztomo commented on pull request #11674:
URL: https://github.com/apache/beam/pull/11674#issuecomment-630549911
No test for this scripts. With this PR, we can setup a Jenkins task to run
the Linkage Checker, say, "Run Java LinkageChecker".
amaliujia commented on pull request #10946:
URL: https://github.com/apache/beam/pull/10946#issuecomment-630548345
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
damondouglas commented on a change in pull request #11734:
URL: https://github.com/apache/beam/pull/11734#discussion_r426996114
##
File path: learning/katas/go/Core Transforms/GroupByKey/GroupByKey/task.md
##
@@ -0,0 +1,50 @@
+
+
+# GroupByKey
+
+GroupByKey is a Beam transform
damondouglas commented on a change in pull request #11734:
URL: https://github.com/apache/beam/pull/11734#discussion_r426996114
##
File path: learning/katas/go/Core Transforms/GroupByKey/GroupByKey/task.md
##
@@ -0,0 +1,50 @@
+
+
+# GroupByKey
+
+GroupByKey is a Beam transform
boyuanzz opened a new pull request #11749:
URL: https://github.com/apache/beam/pull/11749
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
boyuanzz commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-630536199
Latest changes are for addressing comments and using double during
computation. @lukecwik PTAL. Thanks for your help!
TheNeuralBit merged pull request #11528:
URL: https://github.com/apache/beam/pull/11528
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
robertwb commented on a change in pull request #11748:
URL: https://github.com/apache/beam/pull/11748#discussion_r426974286
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##
@@ -183,7 +183,10 @@
lukecwik commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426974548
##
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java
##
@@ -53,9 +53,12
apilloud commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426974365
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/TVFStreamingUtils.java
##
@@ -0,0 +1,24 @@
+/*
+ *
lukecwik commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426973945
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##
@@ -784,7 +877,25 @@ public
lukecwik commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426973945
##
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##
@@ -784,7 +877,25 @@ public
ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426971999
##
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java
##
@@ -195,7 +187,7 @@ public void
lukecwik commented on pull request #11748:
URL: https://github.com/apache/beam/pull/11748#issuecomment-630514195
CC: @ananvay
This is an automated message from the Apache Git Service.
To respond to the message, please log
lukecwik edited a comment on pull request #11748:
URL: https://github.com/apache/beam/pull/11748#issuecomment-630514089
R: @ihji @robertwb
This is an automated message from the Apache Git Service.
To respond to the
lukecwik opened a new pull request #11748:
URL: https://github.com/apache/beam/pull/11748
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
lukecwik commented on pull request #11748:
URL: https://github.com/apache/beam/pull/11748#issuecomment-630514089
R: @y1chi @robertwb
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426969362
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java
##
@@ -0,0 +1,162 @@
+/*
amaliujia commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426968398
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java
##
@@ -175,6 +185,37 @@
aaltay commented on pull request #11674:
URL: https://github.com/apache/beam/pull/11674#issuecomment-630510006
Running the tests. Does any test, actually test this code?
This is an automated message from the Apache Git
aaltay commented on pull request #11437:
URL: https://github.com/apache/beam/pull/11437#issuecomment-630510056
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11674:
URL: https://github.com/apache/beam/pull/11674#issuecomment-630509865
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426967410
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/utils/TVFStreamingUtils.java
##
@@ -0,0 +1,24 @@
+/*
+ *
amaliujia commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426966749
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamTableFunctionScanRel.java
##
@@ -0,0 +1,162 @@
+/*
apilloud commented on a change in pull request #10946:
URL: https://github.com/apache/beam/pull/10946#discussion_r426949818
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/TVFScanConverter.java
##
@@ -0,0
TheNeuralBit commented on pull request #11532:
URL: https://github.com/apache/beam/pull/11532#issuecomment-630495848
Looks like you need to run spotless to auto-format. You can use `./gradlew
spotlessApply` to do that locally (may need to do it on the other PRs as well)
TheNeuralBit commented on pull request #11570:
URL: https://github.com/apache/beam/pull/11570#issuecomment-630495763
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-630495233
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11528:
URL: https://github.com/apache/beam/pull/11528#issuecomment-630494999
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11532:
URL: https://github.com/apache/beam/pull/11532#issuecomment-630494893
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11528:
URL: https://github.com/apache/beam/pull/11528#issuecomment-630494783
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
nielm removed a comment on pull request #11532:
URL: https://github.com/apache/beam/pull/11532#issuecomment-630472990
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
nielm commented on pull request #11532:
URL: https://github.com/apache/beam/pull/11532#issuecomment-630492055
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
nielm commented on pull request #11528:
URL: https://github.com/apache/beam/pull/11528#issuecomment-630492150
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
nielm removed a comment on pull request #11528:
URL: https://github.com/apache/beam/pull/11528#issuecomment-630469413
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
nielm removed a comment on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-630476722
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
nielm commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-630491891
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
nielm commented on pull request #11570:
URL: https://github.com/apache/beam/pull/11570#issuecomment-630491802
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
nielm commented on a change in pull request #11570:
URL: https://github.com/apache/beam/pull/11570#discussion_r426947630
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##
@@ -1171,67 +1145,127 @@ public void
nielm commented on pull request #11570:
URL: https://github.com/apache/beam/pull/11570#issuecomment-630488670
@allenpradeep
> 1. What mode should our import pipeline use? Should it use option b as
data in AVRO seems already sorted?
We can discuss this outside the scope of this
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-630487229
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck commented on a change in pull request #11747:
URL: https://github.com/apache/beam/pull/11747#discussion_r426935903
##
File path: sdks/go/pkg/beam/io/synthetic/source.go
##
@@ -135,27 +155,79 @@ func (fn *sourceFn) ProcessElement(rt
*offsetrange.Tracker, config
tysonjh commented on a change in pull request #11566:
URL: https://github.com/apache/beam/pull/11566#discussion_r426831619
##
File path:
sdks/java/extensions/ml/src/main/java/org/apache/beam/sdk/extensions/ml/BatchRequestForDLP.java
##
@@ -0,0 +1,101 @@
+/*
+ * Licensed to
omarismail94 commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426935461
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##
@@ -347,4
nielm commented on pull request #11529:
URL: https://github.com/apache/beam/pull/11529#issuecomment-630476722
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
omarismail94 commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426931476
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##
@@ -347,4
nielm commented on pull request #11532:
URL: https://github.com/apache/beam/pull/11532#issuecomment-630472990
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
robertwb merged pull request #11708:
URL: https://github.com/apache/beam/pull/11708
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nielm commented on a change in pull request #11532:
URL: https://github.com/apache/beam/pull/11532#discussion_r426929817
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##
@@ -1066,7 +1079,12 @@ public
TheNeuralBit commented on pull request #11528:
URL: https://github.com/apache/beam/pull/11528#issuecomment-630470331
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
suztomo commented on a change in pull request #11674:
URL: https://github.com/apache/beam/pull/11674#discussion_r426927838
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -66,51 +66,61 @@ if [ ! -z "$(git diff)" ]; then
exit 1
fi
+ACCUMULATED_RESULT=0
+
suztomo commented on pull request #11674:
URL: https://github.com/apache/beam/pull/11674#issuecomment-630470049
@aaltay Thank you for taking review. PTAL.
This is an automated message from the Apache Git Service.
To respond
nielm commented on pull request #11528:
URL: https://github.com/apache/beam/pull/11528#issuecomment-630469413
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
nielm commented on a change in pull request #11528:
URL: https://github.com/apache/beam/pull/11528#discussion_r426926639
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
##
@@ -991,6 +1001,24 @@ public
ihji commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426924859
##
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java
##
@@ -195,7 +187,7 @@ public void
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-630465449
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11039:
URL: https://github.com/apache/beam/pull/11039#issuecomment-630465362
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11740:
URL: https://github.com/apache/beam/pull/11740#issuecomment-630462316
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
youngoli commented on pull request #11747:
URL: https://github.com/apache/beam/pull/11747#issuecomment-630460354
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log
youngoli opened a new pull request #11747:
URL: https://github.com/apache/beam/pull/11747
Instead of just creating SourceConfigs and StepConfigs, have a builder
pattern to allow more user-friendly creation of those configs with
defaults.
Thank
omarismail94 commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426918300
##
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##
@@ -4500,6
omarismail94 commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426918114
##
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##
@@ -2836,7
omarismail94 commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426918047
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##
@@ -171,10
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630455763
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11740:
URL: https://github.com/apache/beam/pull/11740#issuecomment-630445775
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
chamikaramj commented on pull request #11740:
URL: https://github.com/apache/beam/pull/11740#issuecomment-630445694
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik opened a new pull request #11746:
URL: https://github.com/apache/beam/pull/11746
This required supporting a translation context through CoderTranslator to
give access to the BeamFnStateClient and current process bundle instruction id.
Thank
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630440098
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
apilloud merged pull request #11272:
URL: https://github.com/apache/beam/pull/11272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630433535
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay commented on pull request #11075:
URL: https://github.com/apache/beam/pull/11075#issuecomment-630432367
/cc @vilobhmm
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aaltay commented on a change in pull request #11075:
URL: https://github.com/apache/beam/pull/11075#discussion_r426889254
##
File path: website/www/site/content/en/documentation/patterns/ai-platform.md
##
@@ -0,0 +1,79 @@
+---
+title: "AI Platform integration patterns"
+---
+
aaltay commented on pull request #11075:
URL: https://github.com/apache/beam/pull/11075#issuecomment-630430689
@kamilwu -- @katsiapis had a few questions. Please do not merge yet, I will
add his comments here.
This is an
robertwb commented on a change in pull request #11039:
URL: https://github.com/apache/beam/pull/11039#discussion_r426876833
##
File path:
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/util/PackageUtilTest.java
##
@@ -195,7 +187,7 @@ public
suztomo commented on a change in pull request #11674:
URL: https://github.com/apache/beam/pull/11674#discussion_r426871194
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -66,51 +66,61 @@ if [ ! -z "$(git diff)" ]; then
exit 1
fi
+ACCUMULATED_RESULT=0
+
rohdesamuel commented on pull request #11745:
URL: https://github.com/apache/beam/pull/11745#issuecomment-630412286
R: @robertwb can you take a look please?
This is an automated message from the Apache Git Service.
To
rohdesamuel opened a new pull request #11745:
URL: https://github.com/apache/beam/pull/11745
Change-Id: Ifd969174d5a7744766173f35fd6b65a72ebfd924
The WriteToBigQuery only has a default implementation which can't
reconstruct the original WriteToBigQuery.
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630408509
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
reuvenlax commented on pull request #11350:
URL: https://github.com/apache/beam/pull/11350#issuecomment-630407268
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630406503
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630406334
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426859494
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##
@@ -347,4
amaliujia commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426859930
##
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##
@@ -4500,6
amaliujia commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426859706
##
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##
@@ -2836,7
iht commented on pull request #11731:
URL: https://github.com/apache/beam/pull/11731#issuecomment-630401560
Thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
amaliujia commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426856451
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##
@@ -171,10
TheNeuralBit opened a new pull request #11744:
URL: https://github.com/apache/beam/pull/11744
R: @aaltay
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex |
TheNeuralBit merged pull request #11743:
URL: https://github.com/apache/beam/pull/11743
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pabloem commented on pull request #11339:
URL: https://github.com/apache/beam/pull/11339#issuecomment-630391792
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
1 - 100 of 174 matches
Mail list logo