ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-655913859
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-655913859
Run XVR_Direct PostCommit
This is an automated message from the Apache Git Service.
To respond to the
ihji commented on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-655912009
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ihji removed a comment on pull request #12060:
URL: https://github.com/apache/beam/pull/12060#issuecomment-655912009
run seed job
This is an automated message from the Apache Git Service.
To respond to the message, please
purbanow commented on a change in pull request #12117:
URL: https://github.com/apache/beam/pull/12117#discussion_r451973374
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java
##
@@ -25,7 +27,9 @@
import
lostluck commented on pull request #11979:
URL: https://github.com/apache/beam/pull/11979#issuecomment-655910522
That works fine. Given how mechanical the change is, it wouldn't be
unreasonable to do the change all at once in one PR.
However, I do recommend doing all the directory
damondouglas commented on pull request #11979:
URL: https://github.com/apache/beam/pull/11979#issuecomment-655901876
@henryken / @lostluck I've started work on consolidating the module by
beginning work at this branch:
damondouglas edited a comment on pull request #11979:
URL: https://github.com/apache/beam/pull/11979#issuecomment-655901876
@henryken / @lostluck I've started work on consolidating the module by
beginning work at this branch:
davidyan74 commented on pull request #12201:
URL: https://github.com/apache/beam/pull/12201#issuecomment-655899856
R: @pabloem
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #11792:
URL: https://github.com/apache/beam/pull/11792#issuecomment-655890489
Found a lot of exclusions before I started getting my disks filled by the
build & local runner.
@robertwb you may be interested in the failures where it seems empty
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655850277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
TheNeuralBit commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655841690
Interesting. Looks like it is running fine on Python PostCommit, and I'm
able to run it locally with the fn api runner as well:
```
python setup.py nosetests --tests
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655830657
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r451872831
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java
##
@@
TheNeuralBit commented on a change in pull request #12202:
URL: https://github.com/apache/beam/pull/12202#discussion_r451889886
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java
##
@@ -15,54 +15,63
apalmercari commented on pull request #11447:
URL: https://github.com/apache/beam/pull/11447#issuecomment-655829440
What changes are required to make it compatible with the dataflow runner
update operation.
This is an
robertwb commented on pull request #12185:
URL: https://github.com/apache/beam/pull/12185#issuecomment-655823773
@aaltay: portable_runner depends on these optimizations (when
--pre_optimize=all) is set to get better fusion.
@yifanmai could you file a jira to run Dataflow through
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-655823253
Run Python 2 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb commented on a change in pull request #12185:
URL: https://github.com/apache/beam/pull/12185#discussion_r451894237
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##
@@ -289,6 +289,8 @@ def create_stages(
phases=[
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-655821747
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem opened a new pull request #12203:
URL: https://github.com/apache/beam/pull/12203
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655795921
Run Python Dataflow ValidatesContainer
This is an automated message from the Apache Git Service.
To respond to
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655795067
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
saavannanavati commented on pull request #11939:
URL: https://github.com/apache/beam/pull/11939#issuecomment-655788900
Tests have passed. This is ready for merge
This is an automated message from the Apache Git Service.
To
TheNeuralBit merged pull request #11744:
URL: https://github.com/apache/beam/pull/11744
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lostluck merged pull request #12193:
URL: https://github.com/apache/beam/pull/12193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sclukas77 opened a new pull request #12202:
URL: https://github.com/apache/beam/pull/12202
Implemented SchemaIO and SchemaCapableIOProvider for Avro and Parquet,
shifting logic to core Beam. Created generalized table and tableprovider
wrappers in Beam SQL, implementing for Pubsub, Avro,
davidcavazos commented on a change in pull request #12188:
URL: https://github.com/apache/beam/pull/12188#discussion_r451817171
##
File path: sdks/python/apache_beam/examples/kafkataxi/README.md
##
@@ -0,0 +1,164 @@
+
+
+# Python KafkaIO Example
+
+This example reads from the
aaltay commented on pull request #12185:
URL: https://github.com/apache/beam/pull/12185#issuecomment-655767371
@yifanmai - (a note from our earlier conversation). This elimination would
not be safe if pardo has side effects or if it is not deterministic. For
example, if pardo is written
aaltay commented on pull request #12185:
URL: https://github.com/apache/beam/pull/12185#issuecomment-655766565
I initially thought this change would only impact fnapi runner and local
execution. I assume the intention is to apply the optimization to all portable
runners. I noticed that
piotr-szuberski removed a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655748822
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655751328
Run XVR_Flink PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655751166
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655625695
@TheNeuralBit I've moved the tests execution to python postcommit suite,
like KafkaIO xlang test. I don't have a clue why they were timing out on
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655748822
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
jaketf commented on pull request #12191:
URL: https://github.com/apache/beam/pull/12191#issuecomment-655748545
CC: @lastomato
This is an automated message from the Apache Git Service.
To respond to the message, please log
davidyan74 opened a new pull request #12201:
URL: https://github.com/apache/beam/pull/12201
…n 20 minutes
This is to be consistent with the behavior of the Java runner. See
https://github.com/apache/beam/pull/12143
Thank you for your
KevinGG commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-655743269
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655734489
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
tvalentyn commented on pull request #12194:
URL: https://github.com/apache/beam/pull/12194#issuecomment-655734353
Run Python Dataflow ValidatesContainer
This is an automated message from the Apache Git Service.
To respond to
tvalentyn merged pull request #12199:
URL: https://github.com/apache/beam/pull/12199
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
tvalentyn commented on pull request #12199:
URL: https://github.com/apache/beam/pull/12199#issuecomment-655733293
Commits are cherry-picks from master, test failures are unrelated (SQL),
there is one known flake (Python Precommit). Merging.
tvalentyn merged pull request #12197:
URL: https://github.com/apache/beam/pull/12197
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ibzib merged pull request #12200:
URL: https://github.com/apache/beam/pull/12200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #12143:
URL: https://github.com/apache/beam/pull/12143#issuecomment-655724129
Thanks @davidyan74 !
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem merged pull request #12143:
URL: https://github.com/apache/beam/pull/12143
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-655719524
@pabloem - Could you merge this if this looks good? I have not reviewed the
PR.
This is an automated message
TheNeuralBit commented on pull request #12200:
URL: https://github.com/apache/beam/pull/12200#issuecomment-655716816
Run SQL PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11744:
URL: https://github.com/apache/beam/pull/11744#issuecomment-655715080
Removing the ValueProvider line didn't actually break any Google tests, but
I lost my resolve to remove it. It seems likely it would break some untested
behavior, e.g.
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r451779380
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on pull request #11639:
URL: https://github.com/apache/beam/pull/11639#issuecomment-655712118
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
amaliujia edited a comment on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-655707048
@darshanj
I believe your implementation will crash this query (at least from ZetaSQL
dialect path)
```
SELECT DISTINCT val.BYTES
from (select b"1"
lukecwik commented on pull request #12192:
URL: https://github.com/apache/beam/pull/12192#issuecomment-655709449
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia commented on pull request #11967:
URL: https://github.com/apache/beam/pull/11967#issuecomment-655707048
@darshanj
I believe your implementation will break this query (at least from ZetaSQL
dialect path)
```
SELECT DISTINCT val.BYTES
from (select b"1" BYTES
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r451772554
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r451761061
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
ibzib opened a new pull request #12200:
URL: https://github.com/apache/beam/pull/12200
R: @reuvenlax @TheNeuralBit
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ]
robertwb commented on a change in pull request #12185:
URL: https://github.com/apache/beam/pull/12185#discussion_r451758742
##
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py
##
@@ -685,6 +687,264 @@ def fix_side_input_pcoll_coders(stages,
tvalentyn commented on pull request #12199:
URL: https://github.com/apache/beam/pull/12199#issuecomment-655695934
R: @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tvalentyn opened a new pull request #12199:
URL: https://github.com/apache/beam/pull/12199
This cherry-picks several commits that unblocks release validation that now
includes Python 3.8 tests.
Since we will run release validation on Python 3.8 as well, also adding a
commit that
kennknowles merged pull request #12120:
URL: https://github.com/apache/beam/pull/12120
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pabloem commented on pull request #12143:
URL: https://github.com/apache/beam/pull/12143#issuecomment-655686932
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tvalentyn edited a comment on pull request #12197:
URL: https://github.com/apache/beam/pull/12197#issuecomment-655686497
Thanks @lazylynx, @kamilwu, @epicfaace for helping with Python 3.8!
This is an automated message from
tvalentyn commented on pull request #12197:
URL: https://github.com/apache/beam/pull/12197#issuecomment-655686497
R: @aaltay. Thanks @lazylynx, @kamilwu, @epicfaace for helping with Python
3.8!
This is an automated
busunkim96 opened a new pull request #12198:
URL: https://github.com/apache/beam/pull/12198
GCP libraries follow semantic versioning, so no breaking changes are made
within a major version. Loosening the range reduces the likelihood of
dependency conflicts for users.
kennknowles commented on pull request #11639:
URL: https://github.com/apache/beam/pull/11639#issuecomment-655686136
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #12196:
URL: https://github.com/apache/beam/pull/12196#issuecomment-655684620
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lostluck commented on pull request #12193:
URL: https://github.com/apache/beam/pull/12193#issuecomment-655678835
Thanks for the pr! Cheers.
This is an automated message from the Apache Git Service.
To respond to the message,
saavannanavati commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r451733706
##
File path: sdks/python/apache_beam/typehints/decorators.py
##
@@ -378,6 +378,56 @@ def has_simple_output_type(self):
self.output_types
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-655672949
@aaltay @pabloem checks seem good now. LMK if this needs anything else
This is an automated message from the
saavannanavati commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r451730259
##
File path: sdks/python/apache_beam/pvalue.py
##
@@ -222,7 +222,7 @@ class _InvalidUnpickledPCollection(object):
pass
-class
robertwb commented on pull request #12196:
URL: https://github.com/apache/beam/pull/12196#issuecomment-655664851
I agree with the severity, especially as we'll be widely advertising
cross-language with the 2.23 release.
robertwb merged pull request #11912:
URL: https://github.com/apache/beam/pull/11912
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on pull request #11968:
URL: https://github.com/apache/beam/pull/11968#issuecomment-655657299
We've been avoiding doing any cythonization at all on Windows due to issues
like this due to statesampler_fast using (unavailable on Windows) posix APIs.
It may be possible to
pabloem commented on pull request #12144:
URL: https://github.com/apache/beam/pull/12144#issuecomment-655651862
taking a look today
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12143:
URL: https://github.com/apache/beam/pull/12143#issuecomment-655643859
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
davidcavazos commented on pull request #12188:
URL: https://github.com/apache/beam/pull/12188#issuecomment-655640853
Should we have a test for this sample as well?
This is an automated message from the Apache Git Service.
To
TheNeuralBit opened a new pull request #12196:
URL: https://github.com/apache/beam/pull/12196
Cherry-pick #12067 into 2.23.0.
The bug this fixes is not technically a regression since it existed in
previous versions as well, but I think it's serious enough to merit cherry
picking
tvalentyn opened a new pull request #12197:
URL: https://github.com/apache/beam/pull/12197
Post-Commit Tests Status (on master branch)
Lang | SDK | Dataflow | Flink | Samza | Spark |
davidcavazos commented on a change in pull request #12188:
URL: https://github.com/apache/beam/pull/12188#discussion_r451686296
##
File path: sdks/python/apache_beam/examples/kafkataxi/kafka_taxi.py
##
@@ -0,0 +1,87 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
aaltay commented on pull request #12049:
URL: https://github.com/apache/beam/pull/12049#issuecomment-655635243
What files will be cleared this way? Release branches leave forever. Would
there be other branches that this script will clean?
aaltay merged pull request #12191:
URL: https://github.com/apache/beam/pull/12191
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jaketf commented on pull request #11959:
URL: https://github.com/apache/beam/pull/11959#issuecomment-655632442
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on a change in pull request #12166:
URL: https://github.com/apache/beam/pull/12166#discussion_r451063093
##
File path: .github/workflows/cancel.yml
##
@@ -16,7 +16,7 @@
# under the License.
name: Cancel
-on: [push]
+on: [push, pull_request]
Review
aaltay commented on pull request #12128:
URL: https://github.com/apache/beam/pull/12128#issuecomment-655629231
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lgajowy commented on a change in pull request #12117:
URL: https://github.com/apache/beam/pull/12117#discussion_r451677939
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java
##
@@ -25,7 +27,9 @@
import
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655625695
@TheNeuralBit I've moved the tests execution to python postcommit suite,
like KafkaIO xlang test. I don't have a clue why they were timing out on
piotr-szuberski edited a comment on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655625695
@TheNeuralBit I've moved the tests execution to python postcommit suite,
like KafkaIO xlang test. I don't have a clue why they failed on
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655625695
@TheNeuralBit I've moved the tests execution to python postcommit suite,
like KafkaIO xlang test. Now the Jdbc tests pass, but I continously have
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655622733
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #12132:
URL: https://github.com/apache/beam/pull/12132#issuecomment-655610830
Great! Thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log
TheNeuralBit merged pull request #12132:
URL: https://github.com/apache/beam/pull/12132
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lostluck commented on pull request #12193:
URL: https://github.com/apache/beam/pull/12193#issuecomment-655600276
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
davidyan74 commented on a change in pull request #12143:
URL: https://github.com/apache/beam/pull/12143#discussion_r451644932
##
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowOperationContext.java
##
@@
TobKed commented on pull request #12049:
URL: https://github.com/apache/beam/pull/12049#issuecomment-655590189
R: @kamilwu @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please
piotr-szuberski commented on pull request #12145:
URL: https://github.com/apache/beam/pull/12145#issuecomment-655588336
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-655587469
Run Chicago Taxi on Dataflow
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-655586849
Run Chicago Taxi on Dataflow
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-655579064
Run Chicago Taxi on Dataflow
This is an automated message from the Apache Git Service.
To respond to the
kamilwu commented on pull request #12195:
URL: https://github.com/apache/beam/pull/12195#issuecomment-655572490
Run Seed Job
This is an automated message from the Apache Git Service.
To respond to the message, please log on
1 - 100 of 138 matches
Mail list logo
