[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656515318 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to t

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656515114 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656514840 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] chamikaramj commented on a change in pull request #11919: [BEAM-10114] Copy Pub/Sub Lite IO from Pub/Sub Lite github to beam.

chamikaramj commented on a change in pull request #11919: URL: https://github.com/apache/beam/pull/11919#discussion_r452650942 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsublite/PubsubLiteIO.java ## @@ -0,0 +1,75 @@ +/* + * Lic

[GitHub] [beam] chamikaramj commented on pull request #12071: [BEAM-9932] Add documentation describing cross-language test pipelines

chamikaramj commented on pull request #12071: URL: https://github.com/apache/beam/pull/12071#issuecomment-656499289 @pskevin please let us know when comments here have been addressed. This is an automated message from the Apa

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656479859 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on a change in pull request #12145: URL: https://github.com/apache/beam/pull/12145#discussion_r452611306 ## File path: sdks/java/io/jdbc/build.gradle ## @@ -25,6 +25,7 @@ description = "Apache Beam :: SDKs :: Java :: IO :: JDBC" ext.summary = "IO to r

[GitHub] [beam] piotr-szuberski commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656471698 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on a change in pull request #12145: URL: https://github.com/apache/beam/pull/12145#discussion_r452611468 ## File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy ## @@ -1982,17 +1982,25 @@ class BeamModulePlugin implements

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on a change in pull request #12145: URL: https://github.com/apache/beam/pull/12145#discussion_r452611151 ## File path: sdks/java/container/boot.go ## @@ -122,6 +122,7 @@ func main() { filepath.Join(jarsDir, "beam-sdks-java-harness.jar")

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on a change in pull request #12145: URL: https://github.com/apache/beam/pull/12145#discussion_r452611306 ## File path: sdks/java/io/jdbc/build.gradle ## @@ -25,6 +25,7 @@ description = "Apache Beam :: SDKs :: Java :: IO :: JDBC" ext.summary = "IO to r

[GitHub] [beam] piotr-szuberski commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

piotr-szuberski commented on a change in pull request #12145: URL: https://github.com/apache/beam/pull/12145#discussion_r452610919 ## File path: CHANGES.md ## @@ -78,6 +78,8 @@ is experimental. It reads data from BigQuery by exporting data to Avro files, and reading those f

[GitHub] [beam] lostluck commented on a change in pull request #12215: [BEAM-10310] Adding thread-safe restriction tracker wrapper.

lostluck commented on a change in pull request #12215: URL: https://github.com/apache/beam/pull/12215#discussion_r452600578 ## File path: sdks/go/pkg/beam/io/synthetic/source.go ## @@ -124,8 +125,8 @@ func (fn *sourceFn) Setup() { // ProcessElement creates a number of random e

[GitHub] [beam] angoenka commented on pull request #12210: [BEAM-10419] Ignore FhirIOWriteIT testFhirIO_Import instead of FhirIO…

angoenka commented on pull request #12210: URL: https://github.com/apache/beam/pull/12210#issuecomment-656450990 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] kennknowles commented on pull request #11792: [BEAM-10435] Add ValidatesRunner task for local_job_service and Java SDK harness

kennknowles commented on pull request #11792: URL: https://github.com/apache/beam/pull/11792#issuecomment-656448688 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [beam] kennknowles commented on pull request #11792: [BEAM-10435] Add ValidatesRunner task for local_job_service and Java SDK harness

kennknowles commented on pull request #11792: URL: https://github.com/apache/beam/pull/11792#issuecomment-656448609 https://ci-beam.apache.org/job/beam_PreCommit_Python_Commit/13653/ appears to be a failure in unrelated code. It does not look like something that would flake. Perhaps `maste

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656447455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [beam] pabloem merged pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

pabloem merged pull request #12144: URL: https://github.com/apache/beam/pull/12144 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] pabloem commented on pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

pabloem commented on pull request #12144: URL: https://github.com/apache/beam/pull/12144#issuecomment-656446787 Thanks Steve! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] saavannanavati commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

saavannanavati commented on pull request #12009: URL: https://github.com/apache/beam/pull/12009#issuecomment-656446634 Tests are passing - just need to resolve a few reviews now :D This is an automated message from the Apache

[GitHub] [beam] steveniemitz commented on pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

steveniemitz commented on pull request #12144: URL: https://github.com/apache/beam/pull/12144#issuecomment-656431891 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] youngoli commented on pull request #12215: [BEAM-10310] Adding thread-safe restriction tracker wrapper.

youngoli commented on pull request #12215: URL: https://github.com/apache/beam/pull/12215#issuecomment-656430039 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [beam] youngoli opened a new pull request #12215: [BEAM-10310] Adding thread-safe restriction tracker wrapper.

youngoli opened a new pull request #12215: URL: https://github.com/apache/beam/pull/12215 Pretty self-explanatory. The wrapper was basic enough that I don't think it makes sense to test it with unit tests. You'd basically just be unit testing the mutex. Instead, I'm testing it in practice

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656427767 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656427767 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] robinyqiu commented on pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

robinyqiu commented on pull request #12214: URL: https://github.com/apache/beam/pull/12214#issuecomment-656422978 Yes. Tested against the compliance tests. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] robinyqiu merged pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

robinyqiu merged pull request #12214: URL: https://github.com/apache/beam/pull/12214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] pabloem edited a comment on pull request #12147: [BEAM 7624] Added Null Behavior in JsonToRow

pabloem edited a comment on pull request #12147: URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531 @reubenvanammers thanks so much for your contribution! can you please resolve the conflicts of your branch, so that we can review the final result? --

[GitHub] [beam] pabloem commented on pull request #12147: [BEAM 7624] Added Null Behavior in JsonToRow

pabloem commented on pull request #12147: URL: https://github.com/apache/beam/pull/12147#issuecomment-656422531 can you please resolve the conflicts of your branch, so that we can review the final result? This is an automate

[GitHub] [beam] tvalentyn edited a comment on pull request #12196: [release-2.23.0][BEAM-10308] Make component ID assignments consistent across Pipeline…

tvalentyn edited a comment on pull request #12196: URL: https://github.com/apache/beam/pull/12196#issuecomment-656278107 This change is currently is not in RC1, and we can consider if for RC2 if there has to be an RC2. The release guildeline clearly say that bugs in new functionality shoul

[GitHub] [beam] steveniemitz commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

steveniemitz commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452565310 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] aaltay commented on pull request #12046: [BEAM-10290] Add a unit(ish) test for dynamic splitting correctness.

aaltay commented on pull request #12046: URL: https://github.com/apache/beam/pull/12046#issuecomment-656419524 > Just for completenes, since we chatted offline: I didn't miss this. I think these are good tests, that just need the rest of the implementation, already partly plumbed in (the n

[GitHub] [beam] aaltay commented on pull request #12147: [BEAM 7624] Added Null Behavior in JsonToRow

aaltay commented on pull request #12147: URL: https://github.com/apache/beam/pull/12147#issuecomment-656419015 R: @pabloem @rezarokni This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] pabloem merged pull request #12107: Interactive Environment Inspector for messaging

pabloem merged pull request #12107: URL: https://github.com/apache/beam/pull/12107 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] ibzib merged pull request #12211: [BEAM-9996] Unshadow test_metrics test for flink_runner_test

ibzib merged pull request #12211: URL: https://github.com/apache/beam/pull/12211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] robinyqiu commented on a change in pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

robinyqiu commented on a change in pull request #12214: URL: https://github.com/apache/beam/pull/12214#discussion_r452558019 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlStdOperatorMappingTable.java ## @@ -29,127 +2

[GitHub] [beam] apilloud commented on a change in pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

apilloud commented on a change in pull request #12214: URL: https://github.com/apache/beam/pull/12214#discussion_r452556681 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlStdOperatorMappingTable.java ## @@ -29,127 +29

[GitHub] [beam] robinyqiu opened a new pull request #12214: [BEAM-10438] Sync ZetaSQL function allowlist with full list from ZetaSQL

robinyqiu opened a new pull request #12214: URL: https://github.com/apache/beam/pull/12214 This PR does not turn on any function or make any functional change. It simply sync the full list of functions from https://github.com/google/zetasql/blob/master/zetasql/public/builtin_function.proto

[GitHub] [beam] tvalentyn commented on pull request #12194: [DO NOT MERGE] Run all PostCommit and PreCommit Tests against Release Branch

tvalentyn commented on pull request #12194: URL: https://github.com/apache/beam/pull/12194#issuecomment-656410102 Run Python Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] steveniemitz commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

steveniemitz commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452553353 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656407977 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn opened a new pull request #12213: Add a blogpost for Apache Beam 2.23.0.

tvalentyn opened a new pull request #12213: URL: https://github.com/apache/beam/pull/12213 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark | T

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656406423 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656406423 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] ihji commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

ihji commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452551623 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public Dataflow

[GitHub] [beam] ibzib commented on pull request #12211: [BEAM-9996] Unshadow test_metrics test for flink_runner_test

ibzib commented on pull request #12211: URL: https://github.com/apache/beam/pull/12211#issuecomment-656405919 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [beam] ihji commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

ihji commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452549676 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public Dataflow

[GitHub] [beam] tvalentyn opened a new pull request #12212: Prepare a website update for 2.23.0

tvalentyn opened a new pull request #12212: URL: https://github.com/apache/beam/pull/12212 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark | T

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656392982 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] steveniemitz commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

steveniemitz commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452536242 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public

[GitHub] [beam] pabloem commented on a change in pull request #12144: [BEAM-10395] Deduplicate uploads by destinations before uploading

pabloem commented on a change in pull request #12144: URL: https://github.com/apache/beam/pull/12144#discussion_r452535839 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/PackageUtil.java ## @@ -311,8 +315,26 @@ public Dataf

[GitHub] [beam] pabloem commented on pull request #12203: Bq main sink

pabloem commented on pull request #12203: URL: https://github.com/apache/beam/pull/12203#issuecomment-656388458 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [beam] y1chi commented on pull request #12210: [BEAM-10419] Ignore FhirIOWriteIT testFhirIO_Import instead of FhirIO…

y1chi commented on pull request #12210: URL: https://github.com/apache/beam/pull/12210#issuecomment-656368121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] kennknowles commented on pull request #11792: Add ValidatesRunner task for local_job_service and Java SDK harness

kennknowles commented on pull request #11792: URL: https://github.com/apache/beam/pull/11792#issuecomment-656364446 PTAL. I have a final set of exclusions, categorized, with all other tests passing locally. The local run took about an hour. I have adjusted `applyPythonNature` to be compati

[GitHub] [beam] kennknowles commented on pull request #11792: Add ValidatesRunner task for local_job_service and Java SDK harness

kennknowles commented on pull request #11792: URL: https://github.com/apache/beam/pull/11792#issuecomment-656364580 I have curated the commits into orthogonal changes, if you wish to focus your review. This is an automated m

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656357766 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656357840 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] ibzib merged pull request #12207: [BEAM-10432] Improve error message for missing pipeline options.

ibzib merged pull request #12207: URL: https://github.com/apache/beam/pull/12207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656331322 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656331322 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452456541 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,28 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python", args...

[GitHub] [beam] mxm opened a new pull request #12211: [BEAM-9996] Unshadow test_metrics test for flink_runner_test

mxm opened a new pull request #12211: URL: https://github.com/apache/beam/pull/12211 `test_metrics` was shadowed by a Flink-specific metrics test. Post-Commit Tests Status (on master branch) --

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656319283 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656319283 run seed job This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] ihji removed a comment on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji removed a comment on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318834 Run Python2_PVR_Flink PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318749 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318962 Run XVR_Direct PostCommit This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [beam] ihji commented on pull request #12060: [BEAM-10218] Add FnApiRunner to cross-language validate runner test

ihji commented on pull request #12060: URL: https://github.com/apache/beam/pull/12060#issuecomment-656318678 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [beam] y1chi opened a new pull request #12210: [BEAM-10419] Ignore FhirIOWriteIT testFhirIO_Import instead of FhirIO…

y1chi opened a new pull request #12210: URL: https://github.com/apache/beam/pull/12210 …ReadIT **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contri

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452448602 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,34 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python", args...

[GitHub] [beam] tvalentyn commented on a change in pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

tvalentyn commented on a change in pull request #12115: URL: https://github.com/apache/beam/pull/12115#discussion_r452448602 ## File path: sdks/python/container/boot.go ## @@ -170,6 +176,34 @@ func main() { log.Fatalf("Python exited: %v", execx.Execute("python", args...

[GitHub] [beam] lukecwik commented on pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

lukecwik commented on pull request #12208: URL: https://github.com/apache/beam/pull/12208#issuecomment-656315133 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [beam] pabloem commented on pull request #12107: Interactive Environment Inspector for messaging

pabloem commented on pull request #12107: URL: https://github.com/apache/beam/pull/12107#issuecomment-656314023 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik edited a comment on pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

lukecwik edited a comment on pull request #12208: URL: https://github.com/apache/beam/pull/12208#issuecomment-656297377 R: @iemejia @TheNeuralBit @jbonofre This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] lukecwik edited a comment on pull request #12209: [BEAM-9629] Fix several connection leak issues.

lukecwik edited a comment on pull request #12209: URL: https://github.com/apache/beam/pull/12209#issuecomment-656297395 R: @iemejia @TheNeuralBit @jbonofre This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452438068 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63 @

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452432390 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java ## @@

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452432390 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java ## @@

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

TheNeuralBit commented on a change in pull request #12145: URL: https://github.com/apache/beam/pull/12145#discussion_r452418029 ## File path: CHANGES.md ## @@ -78,6 +78,8 @@ is experimental. It reads data from BigQuery by exporting data to Avro files, and reading those file

[GitHub] [beam] lukecwik opened a new pull request #12209: [BEAM-9629] Fix several connection leak issues.

lukecwik opened a new pull request #12209: URL: https://github.com/apache/beam/pull/12209 * Make the default max connections to be unlimited. This mirrors the 2.17 and earlier behavior since we used to create one DataSource per execution thread (and hence one connection). * Move connect

[GitHub] [beam] lukecwik commented on pull request #12209: [BEAM-9629] Fix several connection leak issues.

lukecwik commented on pull request #12209: URL: https://github.com/apache/beam/pull/12209#issuecomment-656297395 R: @iemejia @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik commented on pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

lukecwik commented on pull request #12208: URL: https://github.com/apache/beam/pull/12208#issuecomment-656297377 R: @iemejia @TheNeuralBit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] lukecwik opened a new pull request #12208: [BEAM-10433] Swap to use an embedded derby instance instead of starting and waiting for an instance which is unreliable.

lukecwik opened a new pull request #12208: URL: https://github.com/apache/beam/pull/12208 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewer(s)**](https://b

[GitHub] [beam] TheNeuralBit commented on pull request #12145: [BEAM-10136] [BEAM-10135] Add JdbcIO for cross-language with python wrapper

TheNeuralBit commented on pull request #12145: URL: https://github.com/apache/beam/pull/12145#issuecomment-656289151 > Those tests run on Flink and Spark in Python Postcommit suite. Oh really? I didn't realize that. How do you know? I'm having a hard time looking through the logs to

[GitHub] [beam] KevinGG closed pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG closed pull request #11884: URL: https://github.com/apache/beam/pull/11884 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [beam] KevinGG commented on pull request #11884: [BEAM-7923] Initialize an empty Jupyter labextension with README

KevinGG commented on pull request #11884: URL: https://github.com/apache/beam/pull/11884#issuecomment-656286806 We'll discuss the naming and finalize details in the release story before sending out this PR. This is an automa

[GitHub] [beam] ibzib commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

ibzib commented on a change in pull request #12163: URL: https://github.com/apache/beam/pull/12163#discussion_r452406626 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -182,11 +164,10 @@ ResolvedSt

[GitHub] [beam] robinyqiu merged pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

robinyqiu merged pull request #12163: URL: https://github.com/apache/beam/pull/12163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] robinyqiu commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

robinyqiu commented on a change in pull request #12163: URL: https://github.com/apache/beam/pull/12163#discussion_r452405560 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -182,11 +164,10 @@ Resolv

[GitHub] [beam] tvalentyn commented on pull request #12196: [release-2.23.0][BEAM-10308] Make component ID assignments consistent across Pipeline…

tvalentyn commented on pull request #12196: URL: https://github.com/apache/beam/pull/12196#issuecomment-656278107 This change is currently is not in RC1, and we can consider if for RC2 if there has to be an RC2. The release guildeline clearly say that regressions in new functionality shoul

[GitHub] [beam] ibzib opened a new pull request #12207: [BEAM-10432] Improve error message for missing pipeline options.

ibzib opened a new pull request #12207: URL: https://github.com/apache/beam/pull/12207 R: @kennknowles Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] [**Choose reviewe

[GitHub] [beam] KevinGG commented on pull request #12107: Interactive Environment Inspector for messaging

KevinGG commented on pull request #12107: URL: https://github.com/apache/beam/pull/12107#issuecomment-656271632 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mxm commented on a change in pull request #12065: [BEAM-10306] Add latency measurements to Python Flink load test

mxm commented on a change in pull request #12065: URL: https://github.com/apache/beam/pull/12065#discussion_r452361653 ## File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py ## @@ -147,10 +151,18 @@ def process(self, element, state=state_param): C

[GitHub] [beam] sclukas77 commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

sclukas77 commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452346520 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63 @@

[GitHub] [beam] apilloud commented on a change in pull request #12163: [BEAM-9712] Refactor ZetaSQL planner code and support setting default timezone

apilloud commented on a change in pull request #12163: URL: https://github.com/apache/beam/pull/12163#discussion_r452337633 ## File path: sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/SqlAnalyzer.java ## @@ -182,11 +164,10 @@ Resolve

[GitHub] [beam] lazylynx commented on pull request #12115: [BEAM-7672] dynamically setup acceptable wheel specs according to installed python version

lazylynx commented on pull request #12115: URL: https://github.com/apache/beam/pull/12115#issuecomment-656225895 @tvalentyn Updated about wheel name with Python 3.8. PTAL. This is an automated message from the Apache Git Serv

[GitHub] [beam] aaltay edited a comment on pull request #12049: [BEAM-10399] Periodic clear of GCS wheels staging bucket

aaltay edited a comment on pull request #12049: URL: https://github.com/apache/beam/pull/12049#issuecomment-655635243 What files will be cleared this way? Release branches live forever. Would there be other branches that this script will clean?

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452329517 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63 @

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12202: [BEAM-10407,10408] Schema Capable IO Table Provider Wrappers

TheNeuralBit commented on a change in pull request #12202: URL: https://github.com/apache/beam/pull/12202#discussion_r452329517 ## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaIOTableWrapper.java ## @@ -15,54 +15,63 @

  1   2   >