dennisylyung removed a comment on pull request #12583:
URL: https://github.com/apache/beam/pull/12583#issuecomment-725986759
@iemejia I made some changes to use a hashmap for deduplication, and to
improve the test.
I separated the test for duplicate key, and used mockito to check
boyuanzz commented on pull request #13361:
URL: https://github.com/apache/beam/pull/13361#issuecomment-728682733
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz opened a new pull request #13361:
URL: https://github.com/apache/beam/pull/13361
r: @y1chi
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
udim merged pull request #13358:
URL: https://github.com/apache/beam/pull/13358
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ihji commented on pull request #13360:
URL: https://github.com/apache/beam/pull/13360#issuecomment-728673644
R: @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ihji opened a new pull request #13360:
URL: https://github.com/apache/beam/pull/13360
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
boyuanzz merged pull request #13356:
URL: https://github.com/apache/beam/pull/13356
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
udim commented on pull request #13358:
URL: https://github.com/apache/beam/pull/13358#issuecomment-728661421
Run Python_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
udim commented on pull request #13358:
URL: https://github.com/apache/beam/pull/13358#issuecomment-728660986
Run Python_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
rezarokni commented on pull request #13112:
URL: https://github.com/apache/beam/pull/13112#issuecomment-728659985
@kennknowles I wont be able to look at this until the end of the week at the
earliest, is there someone else who can pick this up?
ihji commented on pull request #13356:
URL: https://github.com/apache/beam/pull/13356#issuecomment-728653835
R: @boyuanzz
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
tvalentyn commented on pull request #13359:
URL: https://github.com/apache/beam/pull/13359#issuecomment-728578563
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nehsyc commented on pull request #13292:
URL: https://github.com/apache/beam/pull/13292#issuecomment-728571398
R: @boyuanzz
This is an automated message from the Apache Git Service.
To respond to the message, please log on
TheNeuralBit commented on pull request #13211:
URL: https://github.com/apache/beam/pull/13211#issuecomment-728489376
Run Java Dataflow V2 ValidatesRunner
This is an automated message from the Apache Git Service.
To respond
TheNeuralBit commented on pull request #13211:
URL: https://github.com/apache/beam/pull/13211#issuecomment-728488362
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit merged pull request #13340:
URL: https://github.com/apache/beam/pull/13340
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
y1chi commented on a change in pull request #13350:
URL: https://github.com/apache/beam/pull/13350#discussion_r524486089
##
File path: sdks/python/apache_beam/io/mongodbio.py
##
@@ -241,6 +275,27 @@ def _get_split_keys(self, desired_chunk_size_in_mb,
start_pos, end_pos):
y1chi commented on a change in pull request #13350:
URL: https://github.com/apache/beam/pull/13350#discussion_r524486089
##
File path: sdks/python/apache_beam/io/mongodbio.py
##
@@ -241,6 +275,27 @@ def _get_split_keys(self, desired_chunk_size_in_mb,
start_pos, end_pos):
kileys closed pull request #13289:
URL: https://github.com/apache/beam/pull/13289
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ihji removed a comment on pull request #13356:
URL: https://github.com/apache/beam/pull/13356#issuecomment-728433566
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji commented on pull request #13356:
URL: https://github.com/apache/beam/pull/13356#issuecomment-728433566
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please log
yifanmai commented on pull request #13359:
URL: https://github.com/apache/beam/pull/13359#issuecomment-728433371
R: @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message, please log
yifanmai opened a new pull request #13359:
URL: https://github.com/apache/beam/pull/13359
#13202 introduces a bug where the algorithm that determines the parents of
fused stage can create loops, because the lowest common ancestor algorithm
considers a transform to be its own parent.
TheNeuralBit commented on pull request #13211:
URL: https://github.com/apache/beam/pull/13211#issuecomment-728424003
Run Java_Examples_Dataflow PreCommit
This is an automated message from the Apache Git Service.
To respond
udim commented on pull request #13358:
URL: https://github.com/apache/beam/pull/13358#issuecomment-728411154
R: @TheNeuralBit @robertwb
This is an automated message from the Apache Git Service.
To respond to the message,
udim opened a new pull request #13358:
URL: https://github.com/apache/beam/pull/13358
Continuation of https://github.com/apache/beam/pull/13323
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
veblush opened a new pull request #13357:
URL: https://github.com/apache/beam/pull/13357
Backport of #13311
R:@kennknowles
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
TheNeuralBit commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728384639
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
lostluck commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728382855
Right, I knew this. Python and Java have dataflow in the precommits, which
isn't how the Go SDK organises it's tests, which is why it's a surprise.
SGTM. Merging.
lostluck merged pull request #13347:
URL: https://github.com/apache/beam/pull/13347
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on pull request #13340:
URL: https://github.com/apache/beam/pull/13340#issuecomment-728382082
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
kennknowles commented on pull request #13289:
URL: https://github.com/apache/beam/pull/13289#issuecomment-728374842
We chatted about that. I think the risk of forgetting to add the BOM to a
module is less and the risk of messing up the deps of a module is higher.
Eventually we will want
lostluck merged pull request #13272:
URL: https://github.com/apache/beam/pull/13272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lostluck merged pull request #13348:
URL: https://github.com/apache/beam/pull/13348
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728365075
Well I can't find any documentation stating that Python tests will fail,
just that Dataflow tests will fail. But looking at the last [Python PreCommit
ihji commented on pull request #13356:
URL: https://github.com/apache/beam/pull/13356#issuecomment-728364299
Run Java Dataflow V2 ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the
ihji commented on pull request #13356:
URL: https://github.com/apache/beam/pull/13356#issuecomment-728363769
run xvr_dataflow postcommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji opened a new pull request #13356:
URL: https://github.com/apache/beam/pull/13356
… docker container is cleaned up incorrectly
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this
TheNeuralBit commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728361839
I think it's expected that Python test suites fail on the release branch
until a Dataflow container release. Let me verify that
kennknowles commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-728361655
Great. That's perfect.
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-728359904
> There are no accounts or anything needed for this, right?
See my comment above, I think it's because we didn't want the quickstart
project to require the GCP
rgruener removed a comment on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-728354671
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
rgruener commented on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-728354671
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
rgruener removed a comment on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-728337397
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mxm commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524634584
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
##
@@ -971,7 +987,9 @@ public void
kennknowles commented on pull request #13128:
URL: https://github.com/apache/beam/pull/13128#issuecomment-728348545
A couple years ago I had this same thought ("why are we using pom.xml") and
ended up finding an answer to my satisfaction and not changing it... I don't
remember why, but
kennknowles merged pull request #13311:
URL: https://github.com/apache/beam/pull/13311
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #13311:
URL: https://github.com/apache/beam/pull/13311#issuecomment-728345583
OK then I am happy to merge. It is an experiment and there are no linkage
errors and existing tests pass.
rgruener commented on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-728339372
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
rgruener commented on pull request #13355:
URL: https://github.com/apache/beam/pull/13355#issuecomment-728337397
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
je-ik commented on pull request #13353:
URL: https://github.com/apache/beam/pull/13353#issuecomment-728337299
Do we have a test (in flink runner) for the GBK -> stateful pardo pair? Not
sure if there is one in ValidatesRunner suite.
kennknowles commented on a change in pull request #13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r524593181
##
File path: sdks/java/build-tools/beam-linkage-check.sh
##
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common
je-ik commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524597532
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/WorkItemKeySelector.java
##
@@ -49,6 +52,6 @@ public
kennknowles commented on pull request #13306:
URL: https://github.com/apache/beam/pull/13306#issuecomment-728330950
CombineFn is stable, but UDAF is not. One example is that a UDAF has to have
a SQL type. Right now this is not represented on the UDAF object but is
implied. That might
iemejia commented on pull request #12963:
URL: https://github.com/apache/beam/pull/12963#issuecomment-728329415
Is there something important still missing to get this one merged? Maybe we
can merge and ask/do minor fixes after?
Aliraza-N edited a comment on pull request #13137:
URL: https://github.com/apache/beam/pull/13137#issuecomment-727005597
All done! @pabloem
This is an automated message from the Apache Git Service.
To respond to the
rgruener opened a new pull request #13355:
URL: https://github.com/apache/beam/pull/13355
Combiners have a label constructor argument which is not currently used
correctly.
Thank you for your contribution! Follow this checklist to help us
incorporate
lostluck commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728320640
I'm not worried about the windows failures, but the precommit flake needed a
quick re-run. LGTM and merging.
lostluck edited a comment on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728320640
I'm not worried about the windows failures, but the precommit flake needed a
quick re-run, which appears to be stalled?
lostluck commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728320898
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
robertwb merged pull request #1:
URL: https://github.com/apache/beam/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
boyuanzz merged pull request #13344:
URL: https://github.com/apache/beam/pull/13344
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dmvk commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524545989
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTranslationContext.java
##
@@ -84,6 +85,17 @@ public void
dmvk commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524545316
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/WorkItemKeySelector.java
##
@@ -49,6 +52,6 @@ public
dmvk commented on a change in pull request #13353:
URL: https://github.com/apache/beam/pull/13353#discussion_r524545316
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/WorkItemKeySelector.java
##
@@ -49,6 +52,6 @@ public
boyuanzz commented on pull request #13338:
URL: https://github.com/apache/beam/pull/13338#issuecomment-728292692
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit merged pull request #13128:
URL: https://github.com/apache/beam/pull/13128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kennknowles merged pull request #13259:
URL: https://github.com/apache/beam/pull/13259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #13259:
URL: https://github.com/apache/beam/pull/13259#issuecomment-728284902
Makes sense to me.
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on a change in pull request #13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r524529168
##
File path: sdks/java/container/common.gradle
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
TheNeuralBit commented on a change in pull request #13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r524528475
##
File path: sdks/java/container/build.gradle
##
@@ -86,51 +76,21 @@ licenseReport {
renderers = [new JsonReportRenderer()]
}
-def
boyuanzz commented on a change in pull request #13283:
URL: https://github.com/apache/beam/pull/13283#discussion_r524523450
##
File path: runners/google-cloud-dataflow-java/build.gradle
##
@@ -312,6 +313,36 @@ task validatesRunnerStreaming {
))
}
boyuanzz commented on a change in pull request #13283:
URL: https://github.com/apache/beam/pull/13283#discussion_r524523450
##
File path: runners/google-cloud-dataflow-java/build.gradle
##
@@ -312,6 +313,36 @@ task validatesRunnerStreaming {
))
}
chamikaramj commented on pull request #13235:
URL: https://github.com/apache/beam/pull/13235#issuecomment-728274702
I think the next step is to try out Beam 2.24.0 or later to see if this is
really needed.
This is an
boyuanzz commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524517625
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
KevinGG commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r524516876
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -163,7 +165,8 @@ def __init__(self):
# the gRPC server
KevinGG commented on a change in pull request #13335:
URL: https://github.com/apache/beam/pull/13335#discussion_r524516876
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -163,7 +165,8 @@ def __init__(self):
# the gRPC server
robertwb commented on a change in pull request #1:
URL: https://github.com/apache/beam/pull/1#discussion_r524508497
##
File path: sdks/python/apache_beam/dataframe/transforms.py
##
@@ -410,6 +426,35 @@ def _total_memory_usage(frame):
float('inf')
+class
codecov[bot] edited a comment on pull request #12779:
URL: https://github.com/apache/beam/pull/12779#issuecomment-692856347
# [Codecov](https://codecov.io/gh/apache/beam/pull/12779?src=pr=h1) Report
> Merging
[#12779](https://codecov.io/gh/apache/beam/pull/12779?src=pr=desc) (af2c14c)
lostluck commented on a change in pull request #13272:
URL: https://github.com/apache/beam/pull/13272#discussion_r523124215
##
File path: sdks/go/pkg/beam/core/runtime/metricsx/metricsx_test.go
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
lostluck commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728262843
Run Python 3.8 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728262952
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck commented on pull request #13348:
URL: https://github.com/apache/beam/pull/13348#issuecomment-728262368
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lostluck commented on pull request #13347:
URL: https://github.com/apache/beam/pull/13347#issuecomment-728262680
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck commented on pull request #13275:
URL: https://github.com/apache/beam/pull/13275#issuecomment-728261076
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
TheNeuralBit commented on a change in pull request #1:
URL: https://github.com/apache/beam/pull/1#discussion_r524496438
##
File path: sdks/python/apache_beam/dataframe/transforms.py
##
@@ -223,8 +235,12 @@ def expand(self, pcolls):
# Actually evaluate the
lostluck commented on pull request #13275:
URL: https://github.com/apache/beam/pull/13275#issuecomment-728260568
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lostluck commented on pull request #13275:
URL: https://github.com/apache/beam/pull/13275#issuecomment-728260456
Run Release Gradle Build
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck commented on pull request #13275:
URL: https://github.com/apache/beam/pull/13275#issuecomment-728260032
Hmmm it seems I was mistaken and this did not automatically run all the post
commits. Doing so now.
This is an
robertwb merged pull request #13341:
URL: https://github.com/apache/beam/pull/13341
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on a change in pull request #13341:
URL: https://github.com/apache/beam/pull/13341#discussion_r524496642
##
File path: sdks/python/apache_beam/dataframe/frames.py
##
@@ -1917,9 +1918,12 @@ def func(df, *args, **kwargs):
'__i%s__' % base,
robertwb commented on a change in pull request #13215:
URL: https://github.com/apache/beam/pull/13215#discussion_r524491784
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/ToStringFnRunner.java
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache
TheNeuralBit merged pull request #13331:
URL: https://github.com/apache/beam/pull/13331
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on a change in pull request #13331:
URL: https://github.com/apache/beam/pull/13331#discussion_r524493084
##
File path: website/www/site/assets/icons/extensive-icon.svg
##
@@ -0,0 +1,7 @@
+http://www.w3.org/2000/svg; width="112" height="112" fill="none"
boyuanzz commented on a change in pull request #13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r524491777
##
File path: sdks/java/io/kafka/build.gradle
##
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile
codecov[bot] edited a comment on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-704839820
# [Codecov](https://codecov.io/gh/apache/beam/pull/13026?src=pr=h1) Report
> Merging
[#13026](https://codecov.io/gh/apache/beam/pull/13026?src=pr=desc) (000ac07)
piotr-szuberski commented on pull request #13026:
URL: https://github.com/apache/beam/pull/13026#issuecomment-728249571
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
y1chi commented on a change in pull request #13350:
URL: https://github.com/apache/beam/pull/13350#discussion_r524486089
##
File path: sdks/python/apache_beam/io/mongodbio.py
##
@@ -241,6 +275,27 @@ def _get_split_keys(self, desired_chunk_size_in_mb,
start_pos, end_pos):
piotr-szuberski commented on pull request #12611:
URL: https://github.com/apache/beam/pull/12611#issuecomment-728248437
> Looks good, merging now. Thanks for all your work on this @piotr-szuberski
:)
Thank you too for your reviews! :)
piotr-szuberski opened a new pull request #13354:
URL: https://github.com/apache/beam/pull/13354
R: @iemejia
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
1 - 100 of 164 matches
Mail list logo
