[GitHub] [beam] TheNeuralBit commented on a change in pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

2020-08-04 Thread GitBox
TheNeuralBit commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r465387956 ## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ## @@ -35,33 +38,45 @@ import

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

2020-08-04 Thread GitBox
TheNeuralBit commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r465387416 ## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ## @@ -35,33 +38,45 @@ import

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

2020-08-03 Thread GitBox
TheNeuralBit commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r464702259 ## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ## @@ -99,28 +116,101 @@ private void runRead() {

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12422: [BEAM-601] Run KinesisIOIT with localstack

2020-07-30 Thread GitBox
TheNeuralBit commented on a change in pull request #12422: URL: https://github.com/apache/beam/pull/12422#discussion_r463325571 ## File path: sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java ## @@ -34,34 +35,65 @@ import