[GitHub] [beam] aaltay commented on pull request #12185: [BEAM-10409] Add combiner packing to graph optimizer phases

2020-07-08 Thread GitBox
aaltay commented on pull request #12185: URL: https://github.com/apache/beam/pull/12185#issuecomment-655767371 @yifanmai - (a note from our earlier conversation). This elimination would not be safe if pardo has side effects or if it is not deterministic. For example, if pardo is written

[GitHub] [beam] aaltay commented on pull request #12185: [BEAM-10409] Add combiner packing to graph optimizer phases

2020-07-08 Thread GitBox
aaltay commented on pull request #12185: URL: https://github.com/apache/beam/pull/12185#issuecomment-655766565 I initially thought this change would only impact fnapi runner and local execution. I assume the intention is to apply the optimization to all portable runners. I noticed that