[GitHub] [beam] amaliujia commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-09-17 Thread GitBox
amaliujia commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-694485388 @aaltay this change will break internal test suite. Need to take a closer to know why the suite is broken and how to fix.

[GitHub] [beam] amaliujia commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-27 Thread GitBox
amaliujia commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-682332723 This PR overall looks good! This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [beam] amaliujia commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-23 Thread GitBox
amaliujia commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-678895260 @jhnmora000 Is this PR ready for review? This is an automated message from the Apache Git Service. To respond t

[GitHub] [beam] amaliujia commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-20 Thread GitBox
amaliujia commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-677868705 Hi John, Are there more updates you want to append to this PR or this PR is waiting for review? This i

[GitHub] [beam] amaliujia commented on pull request #12595: [BEAM-9198] BeamSQL aggregation analytics functionality : Add support for Analytic Functions in ZetaSQL

2020-08-17 Thread GitBox
amaliujia commented on pull request #12595: URL: https://github.com/apache/beam/pull/12595#issuecomment-675015548 Thanks! I will try this PR on our internal test suite. This is an automated message from the Apache Git Service