[GitHub] [beam] aromanenko-dev commented on pull request #12572: [BEAM-10123] Add Kafka Commit transform.

2020-11-03 Thread GitBox
aromanenko-dev commented on pull request #12572: URL: https://github.com/apache/beam/pull/12572#issuecomment-721205595 > How about, we check in this PR first if it looks to you, then I'll open another PR to setup the KafkaIO performance test properly? Sounds good me, thanks

[GitHub] [beam] aromanenko-dev commented on pull request #12572: [BEAM-10123] Add Kafka Commit transform.

2020-10-27 Thread GitBox
aromanenko-dev commented on pull request #12572: URL: https://github.com/apache/beam/pull/12572#issuecomment-717262304 @boyuanzz ping on this This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] aromanenko-dev commented on pull request #12572: [BEAM-10123] Add Kafka Commit transform.

2020-09-30 Thread GitBox
aromanenko-dev commented on pull request #12572: URL: https://github.com/apache/beam/pull/12572#issuecomment-701311000 > Yeah I also want to have some tests around this but it may not be possible to involve actual Kafka consumer to do so. The way I can come up is to use mock but I'm not

[GitHub] [beam] aromanenko-dev commented on pull request #12572: [BEAM-10123] Add Kafka Commit transform.

2020-09-25 Thread GitBox
aromanenko-dev commented on pull request #12572: URL: https://github.com/apache/beam/pull/12572#issuecomment-699055049 Thanks! I did a quick look on this - are you going to add some tests for this addition? This is an