subject:"\[GitHub\] \[beam\] boyuanzz commented on pull request #12888\: \[BEAM\-10861\]Moves PubSub Runner API encoding to Read\/Write transforms"

[GitHub] [beam] boyuanzz commented on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-22 Thread GitBox

boyuanzz commented on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696410670 Discussed with Luke and Cham separately, we can get ride of `with_attributes` and `serialized_attribute_fn ` from both Read and Write. There are corresponding changes for

[GitHub] [beam] boyuanzz commented on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-21 Thread GitBox

boyuanzz commented on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696410670 Discussed with Luke and Cham separately, we can get ride of `with_attributes` and `serialized_attribute_fn ` from both Read and Write. There are corresponding changes for

[GitHub] [beam] boyuanzz commented on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-21 Thread GitBox

boyuanzz commented on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696410670 Discussed with Luke and Cham separately, we can get ride of `with_attributes` and `serialized_attribute_fn ` from both Read and Write. There are corresponding changes for