[GitHub] [beam] chamikaramj commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632347848 LGTM. Thanks. Ran the Kafka test few times and it seems to be working. This is an automated message

[GitHub] [beam] chamikaramj commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632314627 I'm doing a manual validation for now. This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] chamikaramj commented on pull request #11781: [BEAM-2939, BEAM-10057] Ensure that we can process an EmptyUnboundedSource and also prevent splitting on it.

2020-05-21 Thread GitBox
chamikaramj commented on pull request #11781: URL: https://github.com/apache/beam/pull/11781#issuecomment-632314521 I suspect test coverage will be internal to Dataflow (hence during import). This is an automated message