[GitHub] [beam] chamikaramj commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-689905869 Please resolve the conflict. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-689905821 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-02 Thread GitBox
chamikaramj commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-685856517 Please keep this in apache_beam.io instead of apache_beam.io.external. There's not much value in differentiating cross-language IO connectors from other connectors. If you