kennknowles commented on a change in pull request #12521: URL: https://github.com/apache/beam/pull/12521#discussion_r468783212
########## File path: sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/SchemaCoderTest.java ########## @@ -290,5 +329,31 @@ public void coderConsistentWithEquals() throws Exception { } } } + + @Test + public void verifyDeterministic() throws Exception { + if (expectDeterministic) { + assertDeterministic(coder); + } else { + assertNonDeterministic(coder); + } + } + } + + private static void assertDeterministic(SchemaCoder coder) { Review comment: There's also https://github.com/apache/beam/blob/0098eb6f9900849b05bfc2ec2497ed8c7d37148a/sdks/java/core/src/main/java/org/apache/beam/sdk/testing/CoderProperties.java#L67 (coder properties are "properties" in the sense of property-driven testing a la QuickCheck) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org