[GitHub] [beam] kw2542 commented on a change in pull request #12617: [BEAM-10670] Update Samza to be opt-out for SplittableDoFn powering the Read transform.

[GitBox]

kw2542 commented on a change in pull request #12617:
URL: https://github.com/apache/beam/pull/12617#discussion_r488820872



##########
File path: 
runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
##########
@@ -106,6 +107,7 @@ public PortablePipelineResult 
runPortablePipeline(RunnerApi.Pipeline pipeline) {
 
   @Override
   public SamzaPipelineResult run(Pipeline pipeline) {
+    SplittableParDo.validateNoPrimitiveReads(pipeline);

Review comment:
       is it expected that we only validate in non-portable mode? i.e. this 
validation does not exist in runPortablePipeline()




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org