[GitHub] [beam] lostluck commented on a change in pull request #11976: [BEAM-10169] - ParDo functions with correct output N in their error messages.

lostluck commented on a change in pull request #11976: URL: https://github.com/apache/beam/pull/11976#discussion_r441157202 ## File path: sdks/go/pkg/beam/pardo_test.go ## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor li

[GitHub] [beam] lostluck commented on a change in pull request #11976: [BEAM-10169] - ParDo functions with correct output N in their error messages.

lostluck commented on a change in pull request #11976: URL: https://github.com/apache/beam/pull/11976#discussion_r440321837 ## File path: sdks/go/pkg/beam/pardo_test.go ## @@ -0,0 +1,54 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor li

[GitHub] [beam] lostluck commented on a change in pull request #11976: [BEAM-10169] - ParDo functions with correct output N in their error messages.

lostluck commented on a change in pull request #11976: URL: https://github.com/apache/beam/pull/11976#discussion_r439765234 ## File path: sdks/go/pkg/beam/pardo.go ## @@ -428,31 +428,20 @@ func ParDoErrorFormatter(doFn interface{}, parDo interface{}) string { parDoName

[GitHub] [beam] lostluck commented on a change in pull request #11976: [BEAM-10169] - ParDo functions with correct output N in their error messages.

lostluck commented on a change in pull request #11976: URL: https://github.com/apache/beam/pull/11976#discussion_r439765118 ## File path: sdks/go/pkg/beam/pardo.go ## @@ -414,7 +414,45 @@ func ParDo6(s Scope, dofn interface{}, col PCollection, opts ...Option) (PCollec func Pa

[GitHub] [beam] lostluck commented on a change in pull request #11976: [BEAM-10169] - ParDo functions with correct output N in their error messages.

lostluck commented on a change in pull request #11976: URL: https://github.com/apache/beam/pull/11976#discussion_r438475207 ## File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go ## @@ -41,3 +45,19 @@ func TestLoadFunction(t *testing.T) { t.Errorf("