[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465224502 ## File path: model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml ## @@ -384,3 +384,31 @@ nested: false

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465223398 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -855,10 +855,21 @@ message StandardCoders { // BOOLEAN:

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465223398 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -855,10 +855,21 @@ message StandardCoders { // BOOLEAN:

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465202931 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -855,10 +855,21 @@ message StandardCoders { // BOOLEAN:

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465213462 ## File path: model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml ## @@ -384,3 +384,31 @@ nested: false

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465202931 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -855,10 +855,21 @@ message StandardCoders { // BOOLEAN:

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465200619 ## File path: model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml ## @@ -384,3 +384,31 @@ nested: false

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465200619 ## File path: model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml ## @@ -384,3 +384,31 @@ nested: false

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465189010 ## File path: model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml ## @@ -384,3 +384,31 @@ nested: false

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-04 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r465181033 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -855,10 +855,21 @@ message StandardCoders { // BOOLEAN:

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-08-03 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r464647966 ## File path: sdks/python/apache_beam/coders/coder_impl.py ## @@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False): return 1

[GitHub] [beam] lostluck commented on a change in pull request #12426: [BEAM-7996] Add support for MapType and Nulls in container types for Python RowCoder

2020-07-30 Thread GitBox
lostluck commented on a change in pull request #12426: URL: https://github.com/apache/beam/pull/12426#discussion_r463208404 ## File path: model/pipeline/src/main/proto/beam_runner_api.proto ## @@ -855,10 +855,21 @@ message StandardCoders { // BOOLEAN: