[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436113097 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -296,6 +299,12 @@ public void accept(WindowedValue

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436112241 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -941,20 +1047,59 @@ private Progress getProgress() {

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436111838 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -632,6 +698,17 @@ public Object restriction() {

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r43686 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -577,26 +586,83 @@ public Instant timestamp(DoFn

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r436111296 ## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java ## @@ -577,26 +586,83 @@ public Instant timestamp(DoFn

[GitHub] [beam] lukecwik commented on a change in pull request #11922: [BEAM-2939] Fix FnApiDoFnRunner to ensure that we output within the correct window when processing a splittable dofn

lukecwik commented on a change in pull request #11922: URL: https://github.com/apache/beam/pull/11922#discussion_r435546832 ## File path: sdks/java/harness/src/test/java/org/apache/beam/fn/harness/FnApiDoFnRunnerTest.java ## @@ -1593,6 +1601,391 @@ public void