[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439592297 ## File path: CHANGES.md ## @@ -58,6 +58,10 @@ * Support for X source added (Java/Python) ([BEAM-X](https://issues.apache.org/jira/browse/BEAM-X)). *

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-12 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r439592201 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -78,6 +72,12 @@ or a table. Pipeline construction will fail with a validation error if

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-06-09 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r437719751 ## File path: sdks/python/apache_beam/io/gcp/big_query_query_to_table_it_test.py ## @@ -254,11 +256,36 @@ def test_big_query_new_types(self):

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-05-21 Thread GitBox
pabloem commented on a change in pull request #11086: URL: https://github.com/apache/beam/pull/11086#discussion_r428877884 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -610,7 +611,8 @@ def __init__( coder=None, use_standard_sql=False,

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-15 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r409090101 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -610,7 +611,8 @@ def __init__(

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-15 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r409021250 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -1570,6 +1584,10 @@ class

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-15 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r409021058 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -609,7 +611,8 @@ def __init__(

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-10 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r406931472 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-10 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r406931239 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-07 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r405014860 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-06 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r404483110 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -663,14 +662,10 @@ def split(self,

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r403338432 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-04-03 Thread GitBox
pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r403337969 ## File path: sdks/python/apache_beam/io/gcp/bigquery.py ## @@ -663,14 +662,10 @@ def split(self,