[GitHub] [beam] pabloem commented on a change in pull request #12082: Standardizing BigQuery job names in Beam Python and Java SDKs

2020-07-30 Thread GitBox
pabloem commented on a change in pull request #12082: URL: https://github.com/apache/beam/pull/12082#discussion_r463295587 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java ## @@ -457,6 +456,22 @@ * for

[GitHub] [beam] pabloem commented on a change in pull request #12082: Standardizing BigQuery job names in Beam Python and Java SDKs

2020-07-23 Thread GitBox
pabloem commented on a change in pull request #12082: URL: https://github.com/apache/beam/pull/12082#discussion_r459756841 ## File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py ## @@ -1465,3 +1465,23 @@ def get_avro_schema_from_table_schema(schema):

[GitHub] [beam] pabloem commented on a change in pull request #12082: Standardizing BigQuery job names in Beam Python and Java SDKs

2020-07-23 Thread GitBox
pabloem commented on a change in pull request #12082: URL: https://github.com/apache/beam/pull/12082#discussion_r459717944 ## File path: sdks/python/apache_beam/io/gcp/bigquery_tools.py ## @@ -1465,3 +1465,23 @@ def get_avro_schema_from_table_schema(schema):

[GitHub] [beam] pabloem commented on a change in pull request #12082: Standardizing BigQuery job names in Beam Python and Java SDKs

2020-07-23 Thread GitBox
pabloem commented on a change in pull request #12082: URL: https://github.com/apache/beam/pull/12082#discussion_r459713758 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryResourceNaming.java ## @@ -0,0 +1,107 @@ +/* +

[GitHub] [beam] pabloem commented on a change in pull request #12082: Standardizing BigQuery job names in Beam Python and Java SDKs

2020-07-23 Thread GitBox
pabloem commented on a change in pull request #12082: URL: https://github.com/apache/beam/pull/12082#discussion_r459700149 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryResourceNaming.java ## @@ -0,0 +1,107 @@ +/* +

[GitHub] [beam] pabloem commented on a change in pull request #12082: Standardizing BigQuery job names in Beam Python and Java SDKs

2020-07-23 Thread GitBox
pabloem commented on a change in pull request #12082: URL: https://github.com/apache/beam/pull/12082#discussion_r459699026 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryResourceNaming.java ## @@ -0,0 +1,107 @@ +/* +